project: Fix and check pyupgrade issues #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
reviewed
Nov 4, 2024
tests/conftest.py
Outdated
| os.path.join(_session_repos, x) for x in | ||
| ['Kconfiglib', 'tagged_repo', 'net-tools', 'zephyr']] | ||
| ['Kconfiglib', 'tagged_repo', 'net-tools', 'zephyr']) |
There was a problem hiding this comment.
I'm curious what was the warning here...
There was a problem hiding this comment.
It was actually a deprecated rule itself, which was still "automagically" fixed with ruff check --fix.
I've ignored this rule.
Derived from pyupgrade, see https://docs.astral.sh/ruff/rules/redundant-open-modes/ Signed-off-by: Pieter De Gendt <[email protected]>
Derived from pyupgrade, see https://docs.astral.sh/ruff/rules/non-pep585-annotation/ Signed-off-by: Pieter De Gendt <[email protected]>
Derived from pyupgrade, see https://docs.astral.sh/ruff/rules/non-pep585-annotation/ Signed-off-by: Pieter De Gendt <[email protected]>
Derived from pyupgrade, see https://docs.astral.sh/ruff/rules/non-pep585-annotation/ Signed-off-by: Pieter De Gendt <[email protected]>
Derived from pyupgrade, see https://docs.astral.sh/ruff/rules/non-pep585-annotation/ Signed-off-by: Pieter De Gendt <[email protected]>
Derived from pyupgrade, see https://docs.astral.sh/ruff/rules/super-call-with-parameters/ Signed-off-by: Pieter De Gendt <[email protected]>
Derived from pyupgrade, see https://docs.astral.sh/ruff/rules/quoted-annotation/ Signed-off-by: Pieter De Gendt <[email protected]>
Derived from pyupgrade, see https://docs.astral.sh/ruff/rules/deprecated-import/ Signed-off-by: Pieter De Gendt <[email protected]>
Derived from pyupgrade, see https://docs.astral.sh/ruff/rules/unicode-kind-prefix/ Signed-off-by: Pieter De Gendt <[email protected]>
Derived from pyupgrade, see https://docs.astral.sh/ruff/rules/f-string/ Signed-off-by: Pieter De Gendt <[email protected]>
Check for deprecated usages in the project when running ruff check. Signed-off-by: Pieter De Gendt <[email protected]>
pdgendt
force-pushed
the
tox-ruff-pyupgrade
branch
from
db0741c
to
39c0493
Compare
marc-hb
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the minimum supported python version (3.9 in our case),
pyupgradewill report deprecated python features.Extend
ruffwithpyupgradechecks.Depends on #762