Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project+ci: Succeed ruff format check but keep a notice annotation #770

Merged
merged 2 commits into from
Dec 3, 2024
Merged

project+ci: Succeed ruff format check but keep a notice annotation #770

merged 2 commits into from
Dec 3, 2024

Commits on Dec 2, 2024

  1. project: Set fixed ruff version 

    Prevent ruff issues being reported by updates of the tool itself.

UP027 has been removed in version 0.8.0, remove it from the ignore list.

Signed-off-by: Pieter De Gendt <[email protected]>
    @pdgendt
    pdgendt committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    5eacc04 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. ci: Change format warning to notice, and succeed the job if step fails 

    Github only has 2 states for the result of a job, either success or
error. A warning state would be nice but isn't available.

We still add a notice to changed files to suggest contributors to
format.

Signed-off-by: Pieter De Gendt <[email protected]>
    @pdgendt
    pdgendt committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    cd3753c View commit details
    Browse the repository at this point in the history