scripts: menuconfig: proper handling of NULL character as input #33347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you send this upstream as well? |
Agree, I would like to have a PR in upstream kconfiglib and a reference to that PR in the commit message for this Zephyr PR before merging. |
Done: |
Fixes: zephyrproject-rtos#33212 Upstream PR: ulfalizer/Kconfiglib#103 Ignoring when user inputs NULL in a text field. menuconfig exits with a python stack trace if NULL is provided as input character, therefore ignore NULL as an input character to prevent this behaviour. A NULL character may be given accidentally by the user through the following ways: - Pressing `Win` key on keyboard (Windows only) - Pressing `<CTRL>-@` / `<CTRL>-2`. Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand
force-pushed
the
issues/33212_fix_nul_char
branch
from
ffbe9a9 to
d516838
Compare
mbolivar-nordic
approved these changes
Mar 15, 2021
|
Thanks, LGTM now! |
carlescufi
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #33212
Upstream PR: ulfalizer/Kconfiglib#103
Ignoring when user inputs NULL in a text field.
menuconfig exits with a python stack trace if NULL is provided as input
character, therefore ignore NULL as an input character to prevent this
behaviour.
A NULL character may be given accidentally by the user through the
following ways:
Winkey on keyboard (Windows only)<CTRL>-@/<CTRL>-2.Signed-off-by: Torsten Rasmussen [email protected]