tests: lib: c_lib: fix test_sqrt double promotion warnings #60593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
|
Seems like you could just change the type of |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Double promotion warnings are generated with the flag -Wdouble-promotion Exponent was defined as a float, but was really be used a double here Change the type of exponent in sqrt from float to double. Signed-off-by: Ryan McClelland <[email protected]>
XenuIsWatching
force-pushed
the
test-sqrt-double-promotion
branch
from
4ba0aee
to
ebc6965
Compare
agreed, done |
keith-packard
approved these changes
Jul 21, 2023
cfriedt
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double promotion warnings are generated with the flag -Wdouble-promotion