logging: sys_t/catalog: fix unaligned access #60604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copying parameters into payload buffer, it is possible that after copying a string over, the pointer to buffer is no longer aligned on 4 or 8 bytes. And some toolchains may decide to treat the copy as aligned since the values being copied are 4 or 8 bytes. This results in unaligned memory access and hardware exception. So change the copy to memcpy to avoid potential unaligned access. Signed-off-by: Daniel Leung <[email protected]>
nashif
approved these changes
Jul 21, 2023
teburd
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying parameters into payload buffer, it is possible that after copying a string over, the pointer to buffer is no longer aligned on 4 or 8 bytes. And some toolchains may decide to treat the copy as aligned since the values being copied are 4 or 8 bytes. This results in unaligned memory access and hardware exception. So change the copy to memcpy to avoid potential unaligned access.