crypto: Add support for ECB to the TinyCrypt shim #69479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rettichschnidi
commented
Feb 26, 2024
rettichschnidi
commented
- Add support for ECB to the TinyCrypt shim
- Improve the test coverage slightly for both shims
rettichschnidi
force-pushed
the
gardena/rs/extend-crypto-shims
branch
from
f740547
to
e96c08f
Compare
rettichschnidi
changed the title
|
Is there anything I can do to get this PR moving forward? |
Thanks a lot for the heads up, will keep in mind. However, until a PSA API makes it into mainline (it seems like it will need some time?), is there any chance this PR (or any other new features in the crypto driver) could be merged? |
rettichschnidi
force-pushed
the
gardena/rs/extend-crypto-shims
branch
2 times, most recently
from
b73a8ee
to
0d297e5
Compare
rettichschnidi
force-pushed
the
gardena/rs/extend-crypto-shims
branch
from
0d297e5
to
ae26487
Compare
rettichschnidi
changed the title
rettichschnidi
force-pushed
the
gardena/rs/extend-crypto-shims
branch
from
ae26487
to
81cdaa2
Compare
This adds ECB support to the TinyCrypt crypto shim. Testing coverage is provided in a separate commit. Signed-off-by: Reto Schneider <[email protected]>
This ensures that the crypto shims actually perform correctly for the algorithms they support. Signed-off-by: Reto Schneider <[email protected]>
This ensures that the ECB support does not get broken. Signed-off-by: Reto Schneider <[email protected]>
rettichschnidi
force-pushed
the
gardena/rs/extend-crypto-shims
branch
from
81cdaa2
to
bf58c93
Compare
rettichschnidi
added a commit
to husqvarnagroup/zephyr
that referenced
this pull request
Sep 25, 2024
This adds ECB support to the TinyCrypt crypto shim. Testing coverage is provided in a separate commit. Upstream: zephyrproject-rtos#69479 Signed-off-by: Reto Schneider <[email protected]> (cherry picked from commit 28d2b80)
|
Giving up because deprecation is happening (#79566). |
|
@rettichschnidi FYI the PSA Crypto API is already (and has already been for some time) available in Zephyr, and supports ECB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.