[Backport v3.5-branch] drivers: can: shell: fully initialize frame before sending and use correct DLC in output #73321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zerorise the CAN frame before filling in data to ensure all data bytes are initialized. Fixes: zephyrproject-rtos#73309 Signed-off-by: Henrik Brix Andersen <[email protected]> (cherry picked from commit fb4f67b)
Print the raw DLC when enqueuing a CAN frame for sending, not the corresponding number of bytes. Fixes: zephyrproject-rtos#73309 Signed-off-by: Henrik Brix Andersen <[email protected]> (cherry picked from commit 6a070ee)
henrikbrixandersen
added
area: CAN
Trivial
henrikbrixandersen
changed the title
alexanderwachter
approved these changes
May 27, 2024
martinjaeger
approved these changes
May 27, 2024
fabiobaltieri
approved these changes
May 27, 2024
jhedberg
approved these changes
May 27, 2024
str4t0m
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6a070ee~2..6a070ee from #73310
Fixes: #73310
Fixes: #73314