Bluetooth: SSP: Improve BR SC only mode #78837
Open
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth
area: Bluetooth Classic
jhedberg
reviewed
Sep 24, 2024
subsys/bluetooth/host/classic/ssp.c
Outdated
Comment on lines
446
to
447
| if (IS_ENABLED(CONFIG_BT_SMP_SC_ONLY) && | ||
| (!(evt->key_type == BT_LK_AUTH_COMBINATION_P256))) { |
There was a problem hiding this comment.
Please fix your split line indentation and alignement. It should be N tabs + 0-7 spaces so that you align right after the ( of the previous line. The clang-format inline annotations point this out as well.
There was a problem hiding this comment.
Yes. I noticed it. I recently discovered that Zephyr's tab occupies 8 character positions.
I was just wondering why there was a compliance issue before. Actually, I pay attention to these formats when making commits.
jhedberg
reviewed
Sep 24, 2024
subsys/bluetooth/host/classic/ssp.c
Outdated
Comment on lines
456
to
457
| LOG_ERR("For SC only mode, link key type should be %d", | ||
| BT_LK_AUTH_COMBINATION_P256); |
lylezhu2012
force-pushed
the
ssp_improve_br_sc_only_mode
branch
from
5151780
to
7de336e
Compare
jhedberg
reviewed
Sep 24, 2024
lylezhu2012
force-pushed
the
ssp_improve_br_sc_only_mode
branch
2 times, most recently
from
a8e779b
to
cab5898
Compare
jhedberg
reviewed
Nov 4, 2024
subsys/bluetooth/host/classic/ssp.c
Outdated
Comment on lines
455
to
456
| LOG_ERR("For SC only mode, link key type should be %d", | ||
| BT_LK_AUTH_COMBINATION_P256); |
There was a problem hiding this comment.
Small improvement still: the convention when we get unexpected/invalid data from the controller is to use LOG_WRN() instead of LOG_ERR().
There was a problem hiding this comment.
Got it. Updated.
Actively disconnect the connection with error code `BT_HCI_ERR_AUTH_FAIL` when the notified link key type is not `BT_LK_AUTH_COMBINATION_P256` in BR SC only mode. Signed-off-by: Lyle Zhu <[email protected]>
lylezhu2012
force-pushed
the
ssp_improve_br_sc_only_mode
branch
from
cab5898
to
8e2527e
Compare
jhedberg
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actively disconnect the connection with error code
BT_HCI_ERR_AUTH_FAILwhen the notified link key type is notBT_LK_AUTH_COMBINATION_P256in BR SC only mode.