Bluetooth: L2CAP_BR: Enable Retransmission and Flow control #78879
Conversation
zephyrbot
added
area: Bluetooth
area: Bluetooth Host
area: Bluetooth Classic
zephyrbot
requested review from
alwa-nordic,
hermabe,
jhedberg,
jori-nordic,
sjanc,
Thalley and
theob-pro
include/zephyr/bluetooth/l2cap.h
Outdated
| #define BT_L2CAP_BR_FCS_NO 0x00 | ||
| /** Frame Check Sequence type. 16-bit FCS. */ | ||
| #define BT_L2CAP_BR_FCS_16BIT 0x01 |
There was a problem hiding this comment.
No tabs for alignment, please (only for indentation)
include/zephyr/bluetooth/l2cap.h
Outdated
| /** Endpoint Link Mode. | ||
| * The value is defined as BT_L2CAP_BR_LINK_MODE_* | ||
| */ | ||
| uint8_t mode; |
There was a problem hiding this comment.
Same here and anywhere else if you did the same. Use just spaces for alignment and tabs for indentation (or to put it in another way: the only place for tabs is in the very beginning of a line - as long as you have some non-tab character on a line there should not be any more tabs anywhere later in the line)
There was a problem hiding this comment.
Note: I know there are inconsistencies wrt this in the Bluetooth code base, but we should try to move toward the convention that I just described.
| config BT_L2CAP_RET | ||
| bool "Bluetooth L2CAP restransmission mode [EXPERIMENTAL]" | ||
| select EXPERIMENTAL | ||
| help | ||
| This option enables Bluetooth L2CAP restransmission mode | ||
|
|
There was a problem hiding this comment.
Please add some CI test cases for this. Right now it seems like the new c-code could be invalid garbage, and yet CI would show all green for this.
There was a problem hiding this comment.
OK. How about to add test code to shell?
There was a problem hiding this comment.
OK. How about to add test code to shell?
If there's some convenient and intuitive way to test this through the shell, then sure, why not.
Enable signaling channel configuration for Retransmission and Flow control feature. Send I-frame and S-frame. Support retransmission and Flow control for sending. Receive and handle I-frame and S-frame. Signed-off-by: Lyle Zhu <[email protected]>
Add mode optional support for BR l2cap connect initiator role. If `chan->rx.optional` is true, set the mode to basic mode instead of return error code `-ENOTSUP`. Signed-off-by: Lyle Zhu <[email protected]>
Add a sub-command set `l2cap` for command set `br`. Move command `l2cap-register` to sub-command set. And rename it to `register`. Add command `connect`, `disconnect`, and `send` for command set `l2cap`. Remove original net buffer pool from `data_pool` to `data_rx_pool`. Add a net buffer pool `data_tx_pool` to for command `send`. Do not wait anymore if no net buffer can be allocated from `data_rx_pool`. Dump all received data in L2CAP data received callback. Signed-off-by: Lyle Zhu <[email protected]>
Add more parameters to command `connect` and `register`, including mode, mode_optional, extended_control, and hold_credit. Add command `credits` to give the rx credit. Signed-off-by: Lyle Zhu <[email protected]>
lylezhu2012
force-pushed
the
br_l2cap_implement_ret_fc
branch
from
ee55bf4
to
aef11fb
Compare
Enable the retransmission, flow control, enhance retransmission, and streaming feature for BR/EDR L2cap.