Add RT700 basic environment support #79376

lucien-nxp · 2024-10-03T15:38:12Z

support gpio/uart function

zephyrbot · 2024-10-03T15:39:12Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_nxp	zephyrproject-rtos/hal_nxp@`99570ee` (master)	zephyrproject-rtos/hal_nxp#444	zephyrproject-rtos/hal_nxp#444/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

soc/nxp/common/Kconfig.flexspi_xip

soc/nxp/imxrt/Kconfig

soc/nxp/imxrt/imxrt7xx/Kconfig

danieldegrasse · 2024-10-03T19:35:57Z

boards/nxp/mimxrt700_evk/doc/index.rst

+high-performance numerical tasks such as audio and image processing and supports both fixed-point and
+floating-point operations.
+
+Note: Due to board isn't launched, the picture is blank


Maybe just don't include an image? I'm not aware of a requirement that we actually have one.

It was announced - maybe you can find a picture here: https://www.nxp.com/products/processors-and-microcontrollers/arm-microcontrollers/i-mx-rt-crossover-mcus/i-mx-rt700-crossover-mcu-with-arm-cortex-m33-npu-dsp-and-gpu-cores:i.MX-RT700

Only release RT700 soc, EVK board don't launch currently. We can't show the board picture currently.

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts

boards/nxp/mimxrt700_evk/doc/index.rst

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu1_defconfig

boards/nxp/mimxrt700_evk/Kconfig.defconfig

boards/nxp/mimxrt700_evk/doc/mimxrt700_evk.webp

boards/nxp/mimxrt700_evk/mimxrt700_evk-pinctrl.dtsi

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0_defconfig

nordicjm · 2024-10-04T08:11:31Z

soc/nxp/imxrt/Kconfig

+config XSPI_CONFIG_BLOCK_OFFSET
+	hex "XSPI config block offset"
+	default 0x0
+	help
+	  XSPI configuration block consists of parameters regarding specific
+	  flash devices including read command sequence, quad mode enablement
+	  sequence (optional), etc. The boot ROM expects XSPI configuration
+	  parameter to be presented in serial nor flash.


why is this not in dts?

soc/nxp/imxrt/imxrt7xx/Kconfig.soc

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts

boards/nxp/mimxrt700_evk/Kconfig.mimxrt700_evk

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts

danieldegrasse · 2024-10-21T18:26:52Z

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts

+		status = "okay";
+		jedec-id = [c2 81 3a];
+		erase-block-size = <4096>;
+		write-block-size = <2>; /* FLASH_MCUX_FLEXSPI_MX25UM51345G_OPI_DTR set */


This doesn't really need to be present, since we have no enablement for XSPI (so this property won't affect anything)

Yes, due to the same flash reused on RT700, I only copied the content from RT500. So do you mean I need to remove these information?

About flexcomm8 set as ok status: I'm sorry I don't know why I added it then(The brain might be down😀)and I have deleted it. Thank you

Yes, please remove this information- we don't have support for the XSPI in Zephyr yet, so this property won't do anything

boards/nxp/mimxrt700_evk/CMakeLists.txt

boards/nxp/mimxrt700_evk/doc/index.rst

drivers/gpio/gpio_mcux.c

danieldegrasse · 2024-10-21T18:43:02Z

drivers/pinctrl/pinctrl_lpc_iocon.c

 int pinctrl_configure_pins(const pinctrl_soc_pin_t *pins, uint8_t pin_cnt,
 			   uintptr_t reg)
 {
 	for (uint8_t i = 0; i < pin_cnt; i++) {
 		uint32_t pin_mux = pins[i];
+#if defined(CONFIG_SOC_SERIES_IMXRT7XX) && defined(CONFIG_SOC_FAMILY_NXP_IMXRT)
+		uint8_t port_no = PORT_NO(pin_mux);


I'd prefer to just transition the entire driver to use this macro definition if possible.

soc/nxp/common/Kconfig.xspi_xip

soc/nxp/imxrt/imxrt7xx/cm33/flash_clock_setup.c

soc/nxp/imxrt/imxrt7xx/cm33/flash_clock_setup.h

soc/nxp/imxrt/imxrt7xx/cm33/soc.c

add rt7xx files related to soc support basic clock enablement add HAS_MCUX_XSPI/HAS_GLIKEY Kconfig add common/Kconfig.xspi_xip file Signed-off-by: Lucien Zhao <[email protected]>

add RT7xx dts files add iocon/gpio/flexcomm/clock instances in dts Signed-off-by: Lucien Zhao <[email protected]>

add nxp,imx-xspi-device.yaml add nxp,imx-xspi-mx25um51345g.yaml add nxp,imx-xspi.yaml Signed-off-by: Lucien Zhao <[email protected]>

add more flexcomm instances clock support to adapt rt700 instances number add xspi clock support Signed-off-by: Lucien Zhao <[email protected]>

Due to there is no port on RT7xx soc, update driver to adapt rt7xx pin mux model(Use IOPCTL_PinMuxSet function to configure pinmux set) Signed-off-by: Lucien Zhao <[email protected]>

update gpio driver to adapt rt7xx gpio model: 1. There is no PORT_Type on RT7xx,so set PORT_Type as void 2. Add port_no parameter in gpio_mcux_config to adapt IOPCTL driver 3. Add gpio-port-offest parameter in blinding, it will help map the relation between index n and gpio port when some soc have domain access attribution. 4. Add code to adapt RT700 GPIO attribute configuration Signed-off-by: Lucien Zhao <[email protected]>

add files related to mimxrt700_evk board add gpio/uart function support on board Signed-off-by: Lucien Zhao <[email protected]>

track rt700 sdk files update PR branch Signed-off-by: Lucien Zhao <[email protected]>

DerekSnell

Hi @lucien-nxp ,
Thank you for addressing my other feedback. Now I just see 1 simple doc change, but an important one. Thank you

DerekSnell · 2024-10-25T16:45:03Z

boards/nxp/mimxrt700_evk/doc/index.rst

+Using LinkServer
+----------------
+
+Linkserver is the default runner for this board, and supports the factory


Suggested change

Linkserver is the default runner for this board, and supports the factory

The Linkserver runner supports the factory

JLink is the default runner in the PR. We need to correct this.

lucien-nxp requested review from mmahadevan108 and dleach02 as code owners October 3, 2024 15:38

zephyrbot added area: Clock Control area: GPIO platform: NXP NXP area: Pinctrl platform: NXP Drivers NXP Semiconductors, drivers labels Oct 3, 2024

zephyrbot requested review from butok, danieldegrasse, dbaluta, decsny, DerekSnell, EmilioCBen, gmarull, henrikbrixandersen, manuargue, MarkWangChinese, mnkp, nordic-krch and yvanderv October 3, 2024 15:39

zephyrbot assigned dleach02 and mmahadevan108 Oct 3, 2024

zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Oct 3, 2024

lucien-nxp force-pushed the add_rt700_baseline_support branch from aebb39a to a8fc58d Compare October 3, 2024 16:42

danieldegrasse reviewed Oct 3, 2024

View reviewed changes

nordicjm requested changes Oct 4, 2024

View reviewed changes

butok reviewed Oct 4, 2024

View reviewed changes

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts Outdated Show resolved Hide resolved

lucien-nxp force-pushed the add_rt700_baseline_support branch 7 times, most recently from 15b6e02 to 198fc99 Compare October 21, 2024 02:27

nordicjm reviewed Oct 21, 2024

View reviewed changes

boards/nxp/mimxrt700_evk/Kconfig.mimxrt700_evk Outdated Show resolved Hide resolved

lucien-nxp force-pushed the add_rt700_baseline_support branch 2 times, most recently from b8e5ed2 to 9d23d56 Compare October 21, 2024 12:06

zephyrbot added manifest-mbedtls manifest-hal_espressif labels Oct 21, 2024

lucien-nxp force-pushed the add_rt700_baseline_support branch from 9d23d56 to b3a7dfc Compare October 21, 2024 12:22

danieldegrasse reviewed Oct 21, 2024

View reviewed changes

DerekSnell requested changes Oct 21, 2024

View reviewed changes

soc/nxp/imxrt/imxrt7xx/cm33/soc.c Outdated Show resolved Hide resolved

lucien-nxp force-pushed the add_rt700_baseline_support branch 3 times, most recently from abb27c2 to d6fb425 Compare October 24, 2024 02:20

lucien-nxp added 8 commits October 24, 2024 16:30

soc: nxp: imxrt: imxrt7xx: add rt7xx soc files

7532f91

add rt7xx files related to soc support basic clock enablement add HAS_MCUX_XSPI/HAS_GLIKEY Kconfig add common/Kconfig.xspi_xip file Signed-off-by: Lucien Zhao <[email protected]>

dts: arm: nxp: add RT7xx dts files

dc9dbf7

add RT7xx dts files add iocon/gpio/flexcomm/clock instances in dts Signed-off-by: Lucien Zhao <[email protected]>

dts: bindings: add the first version binding for nxp,imx-xspi IP

092652b

add nxp,imx-xspi-device.yaml add nxp,imx-xspi-mx25um51345g.yaml add nxp,imx-xspi.yaml Signed-off-by: Lucien Zhao <[email protected]>

drivers: clock_control: update mcux_lpc_syscon_clock.c drivers

36eb69f

add more flexcomm instances clock support to adapt rt700 instances number add xspi clock support Signed-off-by: Lucien Zhao <[email protected]>

drivers: pinctrl: update pinctrl_lpc_iocon.c driver

5c594ee

Due to there is no port on RT7xx soc, update driver to adapt rt7xx pin mux model(Use IOPCTL_PinMuxSet function to configure pinmux set) Signed-off-by: Lucien Zhao <[email protected]>

boards: nxp: add mimxrt700_evk board

14da031

add files related to mimxrt700_evk board add gpio/uart function support on board Signed-off-by: Lucien Zhao <[email protected]>

manifest: update west.yml

37b37d8

track rt700 sdk files update PR branch Signed-off-by: Lucien Zhao <[email protected]>

lucien-nxp force-pushed the add_rt700_baseline_support branch from d6fb425 to 37b37d8 Compare October 24, 2024 08:35

This comment was marked as duplicate.

Sign in to view

DerekSnell requested changes Oct 25, 2024

View reviewed changes

iuliana-prodan self-requested a review October 28, 2024 10:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add RT700 basic environment support #79376

Add RT700 basic environment support #79376

lucien-nxp commented Oct 3, 2024

zephyrbot commented Oct 3, 2024 •

edited

Loading

danieldegrasse Oct 3, 2024

iuliana-prodan Oct 4, 2024

lucien-nxp Oct 16, 2024

nordicjm Oct 4, 2024

danieldegrasse Oct 21, 2024

lucien-nxp Oct 22, 2024

lucien-nxp Oct 22, 2024

danieldegrasse Oct 22, 2024

danieldegrasse Oct 21, 2024

This comment was marked as duplicate.

DerekSnell left a comment

DerekSnell Oct 25, 2024

	Linkserver is the default runner for this board, and supports the factory
	The Linkserver runner supports the factory

Add RT700 basic environment support #79376

Are you sure you want to change the base?

Add RT700 basic environment support #79376

Conversation

lucien-nxp commented Oct 3, 2024

zephyrbot commented Oct 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as duplicate.

DerekSnell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zephyrbot commented Oct 3, 2024 •

edited

Loading