Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

west.yml: MCUboot synchronization from v3.7-branch #80425

Open
wants to merge 2 commits into
base: v3.7-branch
Choose a base branch
from

Conversation

nordicjm
Copy link
Collaborator

@nordicjm nordicjm commented Oct 25, 2024

west.yml: MCUboot synchronization from v3.7-branch

Update Zephyr fork of MCUboot to revision:
1c47465cd111b855168d594782b5b17b154ea703

Brings following Zephyr relevant fixes:

  • 1c47465c boot: zephyr: use EXTRA_CONF_FILE instead of deprecated OVERLAY_CONFIG
  • 8e8ecd91 boot: zephyr: Fix serial recovery for NXP IMX.RT platforms
  • 52c7231a boot: zephyr: Fix Warning 'boot_serial_enter defined but not used'
  • a58d9026 zephyr: hello_world: Fix the main() return type warning
  • 50b7b9ee bootutil: Fix AES and SHA-256 contexts not zeroized with mbedTLS
  • 9b1b95c1 ci: Fix zephyr workflow
  • 809b0e42 bootutil: Add better mode selection checks
  • 0fe7ffd8 ci: Fix FIH Docker image release usage
  • a990c6b6 ci: Update FIH docker to Ubuntu Jammy (22.04)
  • 03d1a443 boot: zephyr: board: Fix nrf54l15pdk Kconfig fragment
  • 323eb8d1 boot: zephyr: MCXN947 currently only does not support swap mode
  • 0a88733d boot_serial: Fix format warning
  • 157547c8 boot_serial: Fix incompatible-pointer-types warning
  • 60ac682a bootutil: loader: Verify image header before checking image
  • 1cd53982 boot: main: avoid unused build warning
  • 587289d6 bootutil: Fix missing include
  • 610b8e2b bootutil: Fix swap move max app size calculation
  • a4800ce0 imgtool: Add missing encodings to emitter tests
  • 80397e0f imgtool: Fix getpub fails for ed25519 key
  • e29a123d docs: release-notes: Add note on name clash fix
  • a375a14d zephyr: Fix issue with sysbuild if something else is named mcuboot
  • 77b03c7f Fix style issues
  • 35bf48c5 boot: Change boot_enc_load to take slot number instead of image
  • 9083649 docs: release-notes: Add note on fixed zephyr RAM load address
  • 24de0fbc boot: zephyr: Fix RAM load chain load address
  • 197287ce imgtool: Bump cryptography library version
  • 7566edaf boot: Move encryption context invalidation to boot_enc_drop.
  • 86b1ef19 boot: Rename boot_enc_decrypt to boot_decrypt_key
  • 597a1996 boot: boot_serial: change logging to debug level
  • 2fa42bfa doc: readme-zephyr: fix the scratch partition example
  • f2971d20 boot: Add missing boot_enc_init
  • 071b3b8e boot: Remove pointless slot identification
  • 2cd6ce9f sim: Fix MCUBOOT_SWAP_USING_SCRATCH defined in direct-xip and ram-load

Fixes #80439

@zephyrbot
Copy link
Collaborator

zephyrbot commented Oct 25, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
mcuboot zephyrproject-rtos/mcuboot@fb2cf0e zephyrproject-rtos/mcuboot@1c47465 (v3.7-branch) zephyrproject-rtos/[email protected]
tf-m-tests zephyrproject-rtos/tf-m-tests@d552e4f zephyrproject-rtos/tf-m-tests@502ea90 (main,v3.7-branch) zephyrproject-rtos/[email protected]
trusted-firmware-m zephyrproject-rtos/trusted-firmware-m@069455b zephyrproject-rtos/trusted-firmware-m@60ebade (v3.7-branch) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@nordicjm
Copy link
Collaborator Author

@sylvioalves can you check failing CI here and let me know if there is a commit in MCUboot needed for this to build properly that has been misses?

@sylvioalves
Copy link
Collaborator

sylvioalves commented Oct 25, 2024

@sylvioalves can you check failing CI here and let me know if there is a commit in MCUboot needed for this to build properly that has been misses?

@nordicjm checking.. btw, there are multiple errors, not only with esp32c3.

@nordicjm
Copy link
Collaborator Author

Ah indeed, seems some commits will need to be removed....

@sylvioalves
Copy link
Collaborator

sylvioalves commented Oct 25, 2024

Edit: The error is the same for all targets as in below.

/__w/zephyr/bootloader/mcuboot/boot/bootutil/src/bootutil_priv.h:68:2: error: #error "MCUBOOT_DIRECT_XIP_REVERT cannot be enabled unless MCUBOOT_DIRECT_XIP is used"
   68 | #error "MCUBOOT_DIRECT_XIP_REVERT cannot be enabled unless MCUBOOT_DIRECT_XIP is used"

Is that something you can work out or it is esp32 (and other socs) that require fixing?

@nordicjm
Copy link
Collaborator Author

Edit: The error is the same for all targets as in below.

/__w/zephyr/bootloader/mcuboot/boot/bootutil/src/bootutil_priv.h:68:2: error: #error "MCUBOOT_DIRECT_XIP_REVERT cannot be enabled unless MCUBOOT_DIRECT_XIP is used"
   68 | #error "MCUBOOT_DIRECT_XIP_REVERT cannot be enabled unless MCUBOOT_DIRECT_XIP is used"

Is that something you can work out or it is esp32 (and other socs) that require fixing?

I'll fix that, the esp one is this:

ccache /opt/toolchains/zephyr-sdk-0.16.8/xtensa-espressif_esp32s3_zephyr-elf/bin/xtensa-espressif_esp32s3_zephyr-elf-gcc -DBOOTLOADER_BUILD -DESP_PLATFORM -DKERNEL -DK_HEAP_MEM_POOL_SIZE=4096 -DNDEBUG -D__ZEPHYR__=1 -I/__w/zephyr/bootloader/mcuboot/boot/zephyr/include -I/__w/zephyr/bootloader/mcuboot/boot/zephyr/targets -I/__w/zephyr/bootloader/mcuboot/boot/bootutil/include -I/__w/zephyr/bootloader/mcuboot/ext/tinycrypt/lib/include -I/__w/zephyr/zephyr/twister-out/esp32s3_devkitm_esp32s3_procpu/samples/sysbuild/with_mcuboot/sample.sysbuild.with_mcuboot/mcuboot/zephyr/include/generated/zephyr -I/__w/zephyr/zephyr/include -I/__w/zephyr/zephyr/twister-out/esp32s3_devkitm_esp32s3_procpu/samples/sysbuild/with_mcuboot/sample.sysbuild.with_mcuboot/mcuboot/zephyr/include/generated -I/__w/zephyr/zephyr/soc/espressif -I/__w/zephyr/zephyr/soc/espressif/common/include -I/__w/zephyr/zephyr/soc/espressif/esp32s3/. -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/include/bt -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../esp_shared/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../esp_shared/components/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../port/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/efuse/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/efuse/private_include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/efuse/esp32s3/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/efuse/esp32s3/private_include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_adc/deprecated/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_common/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_hw_support/dma -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_hw_support/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_hw_support/include/esp_private -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_hw_support/include/hal -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_hw_support/include/soc -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_hw_support/include/soc/esp32s3 -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_hw_support/port/esp32s3 -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_hw_support/port/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_rom/esp32s3 -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_rom/esp32s3/ld -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_rom/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_rom/include/esp32s3 -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_system/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_system/include/esp_private -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_system/port/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_system/port/include/private -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/hal/esp32s3/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/hal/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/hal/include/hal -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/hal/platform_port/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/log/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/soc/esp32s3/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/soc/esp32s3/ld -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/soc/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/xtensa/esp32s3/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/xtensa/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/xtensa/include/esp_private -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/xtensa/include/xtensa -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_timer/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_timer/private_include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/driver/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/driver/deprecated -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/driver/gpio/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/driver/uart/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/driver/touch_sensor/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/driver/touch_sensor/esp32s3/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/driver/spi/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/spi_flash/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/spi_flash/include/spi_flash -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_pm/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/bootloader_support/bootloader_flash/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/bootloader_support/private_include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/bootloader_support/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/heap/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_psram/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_mm/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_netif/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_coex/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_phy/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_phy/include/esp_private -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_phy/esp32s3/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_wifi/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_event/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/wpa_supplicant/esp_supplicant/src -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/wpa_supplicant/esp_supplicant/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/wpa_supplicant/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/wpa_supplicant/include/esp_supplicant -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/wpa_supplicant/port/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/wpa_supplicant/src -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/wpa_supplicant/src/crypto -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/wpa_supplicant/src/utils -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/wpa_supplicant/src/eap_peer -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/mbedtls/port/include -I/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../port/include/boot -I/__w/zephyr/bootloader/mcuboot/boot/bootutil/zephyr/.. -I/__w/zephyr/bootloader/mcuboot/boot/bootutil/zephyr/../include -I/__w/zephyr/bootloader/mcuboot/boot/bootutil/zephyr/../../zephyr/include -I/__w/zephyr/bootloader/mcuboot/boot/bootutil/zephyr/../../../ext/tinycrypt/lib/include -isystem /__w/zephyr/zephyr/lib/libc/minimal/include -isystem /__w/zephyr/zephyr/lib/libc/common/include -fno-strict-aliasing -Werror -Os -imacros /__w/zephyr/zephyr/twister-out/esp32s3_devkitm_esp32s3_procpu/samples/sysbuild/with_mcuboot/sample.sysbuild.with_mcuboot/mcuboot/zephyr/include/generated/zephyr/autoconf.h -ffreestanding -fno-common -g -gdwarf-4 -fdiagnostics-color=always --sysroot=/opt/toolchains/zephyr-sdk-0.16.8/xtensa-espressif_esp32s3_zephyr-elf/xtensa-espressif_esp32s3_zephyr-elf -imacros /__w/zephyr/zephyr/include/zephyr/toolchain/zephyr_stdint.h -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wdouble-promotion -Wno-pointer-sign -Wpointer-arith -Wexpansion-to-defined -Wno-unused-but-set-variable -Werror=implicit-int -fno-pic -fno-pie -fno-asynchronous-unwind-tables -fno-reorder-functions --param=min-pagesize=0 -fno-defer-pop -fmacro-prefix-map=/__w/zephyr/bootloader/mcuboot/boot/zephyr=CMAKE_SOURCE_DIR -fmacro-prefix-map=/__w/zephyr/zephyr=ZEPHYR_BASE -fmacro-prefix-map=/__w/zephyr=WEST_TOPDIR -ffunction-sections -fdata-sections -mlongcalls -Wno-unused-variable -Wno-maybe-uninitialized -fstrict-volatile-bitfields -fdump-rtl-expand -std=c99 -MD -MT CMakeFiles/app.dir/main.c.obj -MF CMakeFiles/app.dir/main.c.obj.d -o CMakeFiles/app.dir/main.c.obj -c /__w/zephyr/bootloader/mcuboot/boot/zephyr/main.c
/__w/zephyr/bootloader/mcuboot/boot/zephyr/main.c:52:10: fatal error: esp_image_loader.h: No such file or directory
   52 | #include <esp_image_loader.h>
      |          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

https://github.com/zephyrproject-rtos/zephyr/actions/runs/11515362961/job/32059151909?pr=80425

@sylvioalves
Copy link
Collaborator

sylvioalves commented Oct 25, 2024

I've updated mcuboot with this locally. I can build without any issues. Still checking.

@nordicjm I did test with build and twister locally. Not a single issue. The only difference is that CI is using sdk 0.16.8 and I am on 0.17.0. Any hints?

@nordicjm nordicjm force-pushed the 37mcubootupdates branch 3 times, most recently from 0babe0f to 557cb3d Compare October 28, 2024 12:49
@nordicjm nordicjm changed the title west.yml: MCUboot synchronization from v37TODO west.yml: MCUboot synchronization from v3.7-branch Oct 28, 2024
@nordicjm nordicjm marked this pull request as ready for review October 28, 2024 12:50
@nordicjm nordicjm linked an issue Oct 28, 2024 that may be closed by this pull request
3 tasks
@nordicjm
Copy link
Collaborator Author

I've updated mcuboot with this locally. I can build without any issues. Still checking.

@nordicjm I did test with build and twister locally. Not a single issue. The only difference is that CI is using sdk 0.16.8 and I am on 0.17.0. Any hints?

Have found the offending commit and removed it

@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Oct 28, 2024
@nordicjm nordicjm self-assigned this Oct 28, 2024
sylvioalves
sylvioalves previously approved these changes Oct 28, 2024
@nordicjm nordicjm added this to the v3.7.1 milestone Oct 29, 2024
butok
butok previously approved these changes Oct 29, 2024
de-nordic
de-nordic previously approved these changes Oct 29, 2024
aescolar
aescolar previously approved these changes Oct 30, 2024
submanifests/optional.yaml Outdated Show resolved Hide resolved
@henrikbrixandersen henrikbrixandersen added the Backport Backport PR and backport failure issues label Nov 4, 2024
@tomi-font tomi-font self-requested a review November 4, 2024 12:51
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Nov 4, 2024
@aescolar aescolar added the DNM This PR should not be merged (Do Not Merge) label Nov 4, 2024
@aescolar
Copy link
Member

aescolar commented Nov 4, 2024

Adding the DNM to ensure nobody merges by mistake while we point to "yo" :).
Feel free to remove the label as soon as that is changed.

Updates TF-M to pull in fixes from 2.1.1, and updates the tests
revision to work with this version

Signed-off-by: Jamie McCrae <[email protected]>
Update Zephyr fork of MCUboot to revision:
  1c47465cd111b855168d594782b5b17b154ea703

Brings following Zephyr relevant fixes:

  - 1c47465c boot: zephyr: use EXTRA_CONF_FILE instead of
    deprecated OVERLAY_CONFIG
  - 8e8ecd91 boot: zephyr: Fix serial recovery for NXP IMX.RT
    platforms
  - 52c7231a boot: zephyr: Fix Warning 'boot_serial_enter defined
    but not used'
  - a58d9026 zephyr: hello_world: Fix the main() return type
    warning
  - 50b7b9ee bootutil: Fix AES and SHA-256 contexts not zeroized
    with mbedTLS
  - 9b1b95c1 ci: Fix zephyr workflow
  - 809b0e42 bootutil: Add better mode selection checks
  - 0fe7ffd8 ci: Fix FIH Docker image release usage
  - a990c6b6 ci: Update FIH docker to Ubuntu Jammy (22.04)
  - 03d1a443 boot: zephyr: board: Fix nrf54l15pdk Kconfig fragment
  - 323eb8d1 boot: zephyr: MCXN947 currently only does not support
    swap mode
  - 0a88733d boot_serial: Fix `format` warning
  - 157547c8 boot_serial: Fix `incompatible-pointer-types` warning
  - 60ac682a bootutil: loader: Verify image header before checking
    image
  - 1cd53982 boot: main: avoid unused build warning
  - 587289d6 bootutil: Fix missing include
  - 610b8e2b bootutil: Fix swap move max app size calculation
  - a4800ce0 imgtool: Add missing encodings to emitter tests
  - 80397e0f imgtool: Fix getpub fails for ed25519 key
  - e29a123d docs: release-notes: Add note on name clash fix
  - a375a14d zephyr: Fix issue with sysbuild if something else is
    named mcuboot
  - 77b03c7f Fix style issues
  - 35bf48c5 boot: Change boot_enc_load to take slot number instead
    of image
  - 9083649 docs: release-notes: Add note on fixed zephyr RAM load
    address
  - 24de0fbc boot: zephyr: Fix RAM load chain load address
  - 197287ce imgtool: Bump cryptography library version
  - 7566edaf boot: Move encryption context invalidation to
    boot_enc_drop.
  - 86b1ef19 boot: Rename boot_enc_decrypt to boot_decrypt_key
  - 597a1996 boot: boot_serial: change logging to debug level
  - 2fa42bfa doc: readme-zephyr: fix the scratch partition example
  - f2971d20 boot: Add missing boot_enc_init
  - 071b3b8e boot: Remove pointless slot identification
  - 2cd6ce9f sim: Fix MCUBOOT_SWAP_USING_SCRATCH defined in
    direct-xip and ram-load
  - 3c2f8375 bootutil: Properly retrieve image headers after
    interrupted swap-scratch
  - fb2cf0ec docs: release-notes: Add note on fixed nordic boards
  - 89807992 boot: zephyr: Fix build for nrf9160dk
  - 2f5a7f47 boot: zephyr: Fix build for thingy53
  - c9e4ab8b boot: zephyr: Fix build for thingy52
  - c06f7bb3 Revert "boot: Add MCUBOOT_HW_KEY support for image
    encryption"
  - 1d79ef35 boot: Fix ASN.1 for mbedtls >= 3.1
  - 86acda9e ext: fiat: Use user-defined assert macro

Signed-off-by: Jamie McCrae <[email protected]>
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Nov 4, 2024
Copy link
Collaborator

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TF-M side looks good other than the missing release note.

@nordicjm
Copy link
Collaborator Author

nordicjm commented Nov 6, 2024

TF-M side looks good other than the missing release note.

Release notes are done by release team for LTS releases

@tomi-font
Copy link
Collaborator

Release notes are done by release team for LTS releases

🤔 @nashif @aescolar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Backport PR and backport failure issues manifest manifest-mcuboot manifest-tf-m-tests manifest-trusted-firmware-m size: XS A PR changing only a single line of code
Projects
Status: To do
Development

Successfully merging this pull request may close these issues.

[v3.7-branch] Update MCUboot to include fixes
8 participants