Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: mesh: Mark BT_MESH_USES_TINYCRYPT as deprecated #80668

Conversation

PavelVPV
Copy link
Collaborator

Since TinyCrypt is deprecated, we need to mark BT_MESH_USES_TINYCRYPT option as deprecated too so it is visible for the customers that they need to switch to MbedTLS.

Since TinyCrypt is deprecated, we need to mark BT_MESH_USES_TINYCRYPT
option as deprecated too so it is visible for the customers that they
need to switch to MbedTLS.

Signed-off-by: Pavel Vasilyev <[email protected]>
@jhedberg
Copy link
Member

@PavelVPV you also need to remove all places that might set this option in the upstream tree (when deprecating something the policy is to not have anything in the upstream tree use it anymore, in particular because CI doesn't accept such configurations and would result in CI failures)

Copy link
Member

@jhedberg jhedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick grep, and it seems there are still users of this in the upstream tree.

@PavelVPV
Copy link
Collaborator Author

@PavelVPV you also need to remove all places that might set this option in the upstream tree (when deprecating something the policy is to not have anything in the upstream tree use it anymore, in particular because CI doesn't accept such configurations and would result in CI failures)

This would duplicate the work has been done and not finished in #79931 which makes no sence, but I wonder how then TinyCrypt deprecation got merged without changing its users as this rule should have also been applied there?

@jhedberg
Copy link
Member

This would duplicate the work has been done and not finished in #79931 which makes no sence, but I wonder how then TinyCrypt deprecation got merged without changing its users as this rule should have also been applied there?

Let's continue the discussion in #release on Discord. I'm not trying to come up with my own rules here but just stating what my understanding of the policy is. I think it's better to have a clear answer before merging anything like this, so that you don't end up with last-minute forced reverts before the final 4.0 release.

@jhedberg
Copy link
Member

@PavelVPV I didn't realize that #79566 was already merged and that sets the Kconfig option as deprecated. It's possible it'll have to be reverted (let's see what the consensus of the release engineering team is).

@PavelVPV PavelVPV closed this Oct 31, 2024
@PavelVPV PavelVPV deleted the deprecate_tinycrypt_option_in_mesh branch October 31, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants