Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: wifi: allow espressif boards to test net/wifi use cases #80785

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sylvioalves
Copy link
Collaborator

This aims to allow Espressif boards to test Wi-Fi drivers without binary blobs. The following changes were added:

  1. Convert NRF_WIFI_BUILD_ONLY_MODE and NXP_WIFI_BUILD_ONLY_MODE to use the same common Kconfig name WIFI_BUILD_ONLY_MODE.
  2. Modify hal_nxp and hal_espressif to support the above change. Include espressif Wi-Fi RF stubs.
  3. Modify all esp32-based boards.yml to allow net tests.

@sylvioalves sylvioalves force-pushed the enh/make_wifi_build_only_global branch from 264b271 to e00ed56 Compare November 3, 2024 00:16
@zephyrbot
Copy link
Collaborator

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_espressif zephyrproject-rtos/hal_espressif@0f18742 zephyrproject-rtos/hal_espressif#358 zephyrproject-rtos/hal_espressif#358/files
hal_nxp zephyrproject-rtos/hal_nxp@4a4741f (master) zephyrproject-rtos/hal_nxp#457 zephyrproject-rtos/hal_nxp#457/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_espressif manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Nov 3, 2024
@sylvioalves sylvioalves force-pushed the enh/make_wifi_build_only_global branch 2 times, most recently from 3c6388f to 42bd0e8 Compare November 3, 2024 00:27
Convert vendor specific **_WIFI_BUILD_ONLY_MODE symbol as global
in order to provide common build flag.

Signed-off-by: Sylvio Alves <[email protected]>
Add stubs to allow building Wi-Fi interface
without binary blobs. Only for CI tests.

Signed-off-by: Sylvio Alves <[email protected]>
Allow espressif platform to be properly tested in CI.

Signed-off-by: Sylvio Alves <[email protected]>
This lets esp32-based boards to be tested regarding
Wi-Fi changes. WIP

Signed-off-by: Sylvio Alves <[email protected]>
@sylvioalves sylvioalves force-pushed the enh/make_wifi_build_only_global branch from 42bd0e8 to 95b4643 Compare November 3, 2024 00:33
@sylvioalves
Copy link
Collaborator Author

sylvioalves commented Nov 3, 2024

@krish2718 @dleach02 As you can see in this PR (commit bd260a9), I have aimed to consolidate the WIFI_BUILD_ONLY_MODE as common Kconfig. I have also submitted a similar approach to BT driver as you can see in #80786.

Please, let me know your thoughts about both. I think that we could rename XXX_BUILD_ONLY_MODE to something more clear as such as XXX_BUILD_WITH_NO_BLOBS or similar.

  1. Are you OK making this WIFI symbol global as in this PR?
  2. Does it sound good renaming it?
  3. We could create a global symbol to be used for both Wi-Fi and BT instead of splitting in 2. Any thoughts? Could be something like CONFIG_BUILD_WITH_NO_BLOBS.

@carlescufi PTAL.

Copy link
Collaborator

@krish2718 krish2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, definitely makes sense to move this to global as it's a common problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking area: Samples Samples area: Sockets Networking sockets area: Wi-Fi Wi-Fi DNM This PR should not be merged (Do Not Merge) manifest manifest-hal_espressif manifest-hal_nxp platform: ESP32 Espressif ESP32 platform: NXP Drivers NXP Semiconductors, drivers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants