IPM fix for esp32s3 targets #80887
Open
IPM fix for esp32s3 targets #80887
+825
−1,063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Samples
zephyrbot
requested review from
andyross,
ceolin,
dcpleung,
kartben,
LucasTambor,
nashif,
nordic-krch,
raffarost and
wmrsouza
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_espressif
DNM
marekmatej
force-pushed
the
bugfix/amp_s3_sample_basic
branch
from
ac2bc4c
to
b355dfa
Compare
uLipe
reviewed
Nov 5, 2024
boards/espressif/esp32s3_devkitm/esp32s3_devkitm_appcpu_defconfig
Outdated
Show resolved
Hide resolved
boards/espressif/esp32s3_devkitm/esp32s3_devkitm_procpu_defconfig
Outdated
Show resolved
Hide resolved
marekmatej
force-pushed
the
bugfix/amp_s3_sample_basic
branch
5 times, most recently
from
9771fe2
to
6433c35
Compare
uLipe
reviewed
Nov 5, 2024
marekmatej
force-pushed
the
bugfix/amp_s3_sample_basic
branch
4 times, most recently
from
f6d7b17
to
c8c9a15
Compare
uLipe
reviewed
Nov 5, 2024
marekmatej
force-pushed
the
bugfix/amp_s3_sample_basic
branch
4 times, most recently
from
b50d570
to
c17cb8f
Compare
marekmatej
changed the title
uLipe
previously approved these changes
Nov 6, 2024
added 6 commits
November 6, 2024 19:52
Fetch latest features to support fixes. Signed-off-by: Marek Matej <[email protected]>
Align the shared memories with the memory.h layout. Reorder nodes to show memory related nodes together. Signed-off-by: Marek Matej <[email protected]>
Fix missing flash and code partition. Add missing dts entries and use common partition tables to all related non-Espressif boards, previously ommited. Add uart1 node in pinctrl for APPCPU. Signed-off-by: Marek Matej <[email protected]>
Avoid APPCPU to interact with a clock settings. Fix warning when LOG_LEVEL_DBG. Signed-off-by: Marek Matej <[email protected]>
Updates and fixes to support APPCPU. - fix ld scripts - fix and update memory layout - fix build issues - fix sysbuild Signed-off-by: Marek Matej <[email protected]>
Updates and fixes to support IPM sample on ESP32: - fix IPM sample code for APPCPU and PROCPU - align with memory layout, add flash awarenes - shell commands to stop/start APPCPU - reorganize overlays Signed-off-by: Marek Matej <[email protected]>
marekmatej
force-pushed
the
bugfix/amp_s3_sample_basic
branch
from
c17cb8f
to
4f16991
Compare
uLipe
approved these changes
Nov 6, 2024
sylvioalves
approved these changes
Nov 6, 2024
|
@mmahadevan108 any chance to put this into the 4.0? Thank you :) |
|
pinging @nordicjm for a review from HWV2 side as these samples were broken since the switch to HWV2. |
wmrsouza
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes how the APPCPU is being built in IPM samples. C array encapsulation is removed and instead normal build procedure is used. Fixing the
sysbuildbuilds as well.Fixes #80890