Bluetooth: Controller: Fix spurious ISO Sync receiver stall #80894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix spurious ISO Sync Receiver stall due to uninitialised value accessed due to regression introduced by commit 64facee ("Bluetooth: controller: Stop Sync ISO ticker when establishment fails"). Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
aescolar
requested review from
cvinayak and
Thalley
and removed request for
cvinayak
zephyrbot
requested review from
carlescufi,
erbr-ot,
kruithofa,
mtpr-ot,
thoh-ot and
wopu-ot
aescolar
requested review from
cvinayak
and removed request for
carlescufi,
erbr-ot,
kruithofa,
mtpr-ot,
thoh-ot and
wopu-ot
aescolar
requested review from
carlescufi,
thoh-ot,
erbr-ot,
wopu-ot,
mtpr-ot and
kruithofa
aescolar
added
bug
|
What's preventing us from merging #80775 as a hotfix? |
|
@cvinayak this commit makes the linked issue pass. That issue is currently triggering in quite a few PRs.
@Thalley that PR is also including configuration changes to a test. We are past RC2 so in principle that would require an exception. If those configuration changes are not needed right now, instead of complicating things, I think it is best to just merge this. |
Thalley
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix spurious ISO Sync Receiver stall due to uninitialised value accessed due to regression introduced by
commit 64facee ("Bluetooth: controller: Stop Sync ISO ticker when establishment fails").
Cherry-pick of the bugfix from #80775 so it can go in right away as a hotfix
Fixes #80734
This is just the first commit from from #80775 as is. So that we can have a path to fix the linked issue even if it would be considered to late to merge that whole PR as is.