tests: posix: common: separate posix semaphore tests into a standalone test #80940
+61
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pancakem
force-pushed
the
origin/separate_posix_semaphores_test_into_standalone_test
branch
from
a0647b8
to
473dbb5
Compare
cfriedt
reviewed
Nov 6, 2024
Pancakem
force-pushed
the
origin/separate_posix_semaphores_test_into_standalone_test
branch
from
473dbb5
to
af1f190
Compare
cfriedt
reviewed
Nov 6, 2024
cfriedt
reviewed
Nov 6, 2024
cfriedt
reviewed
Nov 6, 2024
cfriedt
reviewed
Nov 6, 2024
cfriedt
reviewed
Nov 6, 2024
There was a problem hiding this comment.
please rename this file to main.c and also change the suite name from semaphore to posix_semaphores to match the option group name (each of the ZTEST lines will need to be updated too)
There was a problem hiding this comment.
Okay. Just to get it straight for all the tests.
- If it is a single source file, I should make it
main.c. - suite name, project name in Cmake and tag name in
testcase.yamlshould match the option group name. - target libaries should not be included. I am curious about this, if you can shed some light on it.
Is there anything I am missing?
There was a problem hiding this comment.
Okay. Just to get it straight for all the tests.
- If it is a single source file, I should make it
main.c.
Yes, thanks.
- suite name, project name in Cmake and tag name in
testcase.yamlshould match the option group name.
Yep
- target libaries should not be included. I am curious about this, if you can shed some light on it.
There shouldn't be any need to add the library directory to to the application's include paths. This is mainly because the library directory (lib/posix/options) would normally only have private header, and tests should be run against public API.
Is there anything I am missing?
I think that's about it. Thanks for all of your work here 🙏
cfriedt
reviewed
Nov 6, 2024
Pancakem
force-pushed
the
origin/separate_posix_semaphores_test_into_standalone_test
branch
3 times, most recently
from
8fba314
to
1b595b3
Compare
… test posix.common contains testsuites that can be separated into smaller groups of tests. This change moves semaphore into a singular testsuite at tests/posix/semaphores app directory. Signed-off-by: Marvin Ouma <[email protected]>
Pancakem
force-pushed
the
origin/separate_posix_semaphores_test_into_standalone_test
branch
from
1b595b3
to
05fd4f7
Compare
cfriedt
approved these changes
Nov 7, 2024
|
@Pancakem - please apply this diff diff --git a/tests/posix/semaphores/testcase.yaml b/tests/posix/semaphores/testcase.yaml
index 2ad9053724c..92fdebbd992 100644
--- a/tests/posix/semaphores/testcase.yaml
+++ b/tests/posix/semaphores/testcase.yaml
@@ -7,10 +7,10 @@ common:
platform_key:
- arch
- simulation
+ min_flash: 64
+ min_ram: 32
tests:
- portability.posix.semaphores:
- min_flash: 64
- min_ram: 32
+ portability.posix.semaphores: {}
portability.posix.semaphores.minimal:
extra_configs:
- CONFIG_MINIMAL_LIBC=y |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80964
posix.common contains testsuites that can be separated into smaller groups of tests. This change moves semaphore into a singular testsuite at tests/posix/semaphore app directory.