tests: drivers: ipm: Fix drivers.ipc.mailbox #81032
Open
+45
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golowanow
added
the
area: Tests
dcpleung
previously approved these changes
Nov 7, 2024
gmarull
reviewed
Nov 7, 2024
tests/drivers/ipm/src/main.c
Outdated
| @@ -32,9 +32,9 @@ extern struct ipm_driver_api ipm_dummy_api; | |||
|
|
|||
| /* Set up the dummy IPM driver */ | |||
| struct ipm_dummy_driver_data ipm_dummy0_driver_data; | |||
| DEVICE_DEFINE(ipm_dummy0, "ipm_dummy0", NULL, | |||
| DEVICE_DEFINE(ipm_dummy0, "ipm_dummy0", ipm_dummy_init, | |||
There was a problem hiding this comment.
why is a dummy init call needed?
There was a problem hiding this comment.
to check the dummy device for this test that it pass init stage
There was a problem hiding this comment.
Device successful init needs to be tested by getting a valid reference when using device_get_binding, not by inserting dummy calls
There was a problem hiding this comment.
What is the problem to check the init this way for this test's purposes ?
(device_get_binding() check is added as well)
golowanow
force-pushed
the
fix_tests_drivers_ipm_20241106
branch
from
253c402
to
c3b67da
Compare
Closed
gmarull
reviewed
Nov 7, 2024
Fix 'drivers.ipc.mailbox' test suite to restore and improve its testing functionality: * fix printf() redirection through IPM console. * fix and check the dummy driver initialization. * specify correct Twister harness type (Console) and use matching patterns to recognize the expected console output. Signed-off-by: Dmitrii Golovanov <[email protected]>
golowanow
force-pushed
the
fix_tests_drivers_ipm_20241106
branch
from
c3b67da
to
e31351b
Compare
gmarull
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
drivers.ipc.mailboxtest suite to restore and improve its testing functionality:fix printf() redirection through IPM console.
fix and check the dummy driver initialization.
specify correct Twister harness type (Console) and use matching patterns to recognize the expected console output.
Before the fix:
./scripts/twister -p qemu_x86 -T tests/drivers/ipmwith the fix: