Transparent error code propagation in CAN MCAN module #82430
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KozhinovAlexander
force-pushed
the
can_mcan_error_propagation
branch
from
f0f41d9
to
757915c
Compare
The implementation of can_mcan_start() function hides retun code of underlying function. It makes root-cause search more difficult. This change strives fro transparent error code propagation to higher software layers. Signed-off-by: Alexander Kozhinov <[email protected]>
KozhinovAlexander
force-pushed
the
can_mcan_error_propagation
branch
from
757915c
to
e7f149a
Compare
martinjaeger
approved these changes
Dec 2, 2024
henrikbrixandersen
approved these changes
Dec 2, 2024
jilaypandya
reviewed
Dec 3, 2024
| @@ -292,7 +292,7 @@ int can_mcan_start(const struct device *dev) | |||
| { | |||
| const struct can_mcan_config *config = dev->config; | |||
| struct can_mcan_data *data = dev->data; | |||
| int err; | |||
| int err = 0; | |||
There was a problem hiding this comment.
Just for my understanding.
Is this change in l295 really required? I don't see any code path where err would be read before getting assigned to some value.
There was a problem hiding this comment.
I was thinking the same. But I thought it would be OK to keep it for clarity reasons. We are returning err at the end now, so one one does not have to check every path in the code whether err is guaranteed to have a valid value.
jilaypandya
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of can_mcan_start() function hides retun code of underlying function, which makes root-cause search mure difficult.
This change strives fro transparent error code propagation to higher software layers.