tests: drivers: audio: dmic_api: Enable test execution on nrf54l15 #82436
+45
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
jaz1-nordic,
kl-cruz,
kv2019i,
lgirdwood,
lyakh,
magp-nordic,
masz-nordic and
nika-nordic
|
FYI: @mstasiaknordic , @nordic-piks |
nordic-segl
commented
Dec 2, 2024
| @@ -365,7 +365,6 @@ static int dmic_nrfx_pdm_configure(const struct device *dev, | |||
|
|
|||
| channel->act_num_streams = 1; | |||
| channel->act_chan_map_hi = 0; | |||
| channel->act_chan_map_lo = def_map; | |||
There was a problem hiding this comment.
Here is test with LEFT/RIGHT channels swapped:
https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/drivers/audio/dmic_api/src/main.c#L158
Without this change, test is failing on this assert:
https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/drivers/audio/dmic_api/src/main.c#L94
In current/previous implementation, actual channel map is always def_map.
Even if the user requested values equal to the alt_map.
Enable execution of dmic_api test on nrf54l15: - add 'dmic' to the list of supported peripherals; - add overlay for nrf54l15; - align Nordic's implementation of PDM driver to pass the test. Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
force-pushed
the
NRFX-6619_Enable-PDM-driver-test-on-nrf54l15
branch
from
7ea2a8d
to
8ad6bed
Compare
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 3, 2024
tests: drivers: audio: dmic_api: Enable test execution on nrf54l15 nrfconnect/sdk-zephyr#2325 zephyrproject-rtos/zephyr#82436 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 3, 2024
tests: drivers: audio: dmic_api: Enable test execution on nrf54l15 nrfconnect/sdk-zephyr#2325 zephyrproject-rtos/zephyr#82436 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 3, 2024
tests: drivers: audio: dmic_api: Enable test execution on nrf54l15 nrfconnect/sdk-zephyr#2325 zephyrproject-rtos/zephyr#82436 Signed-off-by: Sebastian Głąb <[email protected]>
mstasiaknordic
approved these changes
Dec 3, 2024
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 3, 2024
tests: drivers: audio: dmic_api: Enable test execution on nrf54l15 nrfconnect/sdk-zephyr#2325 zephyrproject-rtos/zephyr#82436 Signed-off-by: Sebastian Głąb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable execution of dmic_api test on nrf54l15: