Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jlink: west command testing #82445

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jcpi-q
Copy link
Contributor

@jcpi-q jcpi-q commented Dec 2, 2024

Adds some tests to the jlink runner.

@pdgendt
Copy link
Collaborator

pdgendt commented Dec 3, 2024

I'd suggest modifying the workflow file:

diff --git a/.github/workflows/west_cmds.yml b/.github/workflows/west_cmds.yml
index d7b671bc7e7..cc66ba7db78 100644
--- a/.github/workflows/west_cmds.yml
+++ b/.github/workflows/west_cmds.yml
@@ -63,10 +63,10 @@ jobs:
         key: ${{ runner.os }}-pip-${{ matrix.python-version }}
         restore-keys: |
           ${{ runner.os }}-pip-${{ matrix.python-version }}
-    - name: install pytest
+    - name: install python dependencies
       run: |
         pip3 install wheel
-        pip3 install pytest west pyelftools canopen natsort progress mypy intelhex psutil ply pyserial anytree
+        pip3 install pytest west pyelftools canopen natsort progress mypy intelhex psutil ply pyserial anytree pylink-square
     - name: run pytest-win
       if: runner.os == 'Windows'
       run: |

@pdgendt
Copy link
Collaborator

pdgendt commented Dec 3, 2024

Sorry, it appears to be pylink-square, also re-order your commit so the CI one is first.

pdgendt and others added 2 commits December 3, 2024 18:23
Adds pylink dependency for jlink testing.

Signed-off-by: Pieter De Gendt <[email protected]>
Adds some tests to the jlink runner.

Signed-off-by: Jean-Christophe Pince <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants