Support rtwdog on rt1180 #82456
Support rtwdog on rt1180 #82456
Conversation
zephyrbot
added
area: Watchdog
zephyrbot
requested review from
butok,
danieldegrasse,
dbaluta,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
katsuster,
manuargue,
MarkWangChinese,
martinjaeger,
mmahadevan108 and
yvanderv
|
Related hal_nxp PR: zephyrproject-rtos/hal_nxp#482 |
Please record your hal_nxp PR in west.yml like : |
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nxp
DNM
Port NXP rtwdog driver to Zephyr. Signed-off-by: Ruijia Wang <[email protected]>
RT1180 takes reset event mask feature which should be unmasked when watch dog is enabled. Signed-off-by: Ruijia Wang <[email protected]>
Sync pr for test. Signed-off-by: Ruijia Wang <[email protected]>
SuperHeroAbner
force-pushed
the
support-rtwdog-on-rt1180
branch
from
75c3eb8
to
cafbea5
Compare
|
|
||
| description: imxRT watchdog | ||
|
|
||
| compatible: "nxp,imx-rtwdog" |
There was a problem hiding this comment.
Let's avoid using imx in the compatible name, this IP will probably be reused outside of the i.MX RT line at some point.
I'd suggest the compatible nxp,rtwdog
| @@ -0,0 +1,28 @@ | |||
| # Copyright (c) 2018, NXP | |||
There was a problem hiding this comment.
| # Copyright (c) 2018, NXP | |
| # Copyright 2024, NXP |
| @@ -0,0 +1,222 @@ | |||
| /* | |||
| * Copyright (C) 2024, NXP | |||
There was a problem hiding this comment.
| * Copyright (C) 2024, NXP | |
| * Copyright 2024, NXP |
| #define MSEC_TO_RTWDOG_TICKS(clock_freq, divider, msec) \ | ||
| ((uint32_t)(clock_freq * msec / 1000U / divider)) | ||
|
|
||
| #ifndef U16_MAX |
There was a problem hiding this comment.
Why not include <stdint.h> and use UINT16_MAX
|
|
||
| config->irq_config_func(dev); | ||
|
|
||
| ret = pinctrl_apply_state(config->pcfg, PINCTRL_STATE_DEFAULT); |
There was a problem hiding this comment.
Why do we need a pin setting for this watchdog? It seems to have no external signals
|
|
||
| static struct mcux_rtwdog_data mcux_rtwdog_data; | ||
|
|
||
| DEVICE_DT_INST_DEFINE(0, &mcux_rtwdog_init, NULL, &mcux_rtwdog_data, &mcux_rtwdog_config, |
There was a problem hiding this comment.
Let's not use this syntax here, this driver can easily be multi instance. Take a look at this driver for an example of a multi-instance watchdog setup:
zephyr/drivers/watchdog/wdt_gecko.c
Line 281 in 537b52e
| clk-divider: | ||
| type: int | ||
| description: Watchdog counter clock divider | ||
| required: true |
There was a problem hiding this comment.
Missing newline at end of file
| @@ -56,6 +59,14 @@ static const clock_arm_pll_config_t armPllConfig_BOARD_BootClockRUN = { | |||
| }; | |||
| #endif | |||
|
|
|||
| #if defined(CONFIG_WDT_MCUX_IMX_RTWDOG) | |||
| #define RTWDOG_IF_SET_SRC(n, i) \ | |||
| if (strcmp(DT_PROP(DT_NODELABEL(rtwdog##n), status), "okay") == 0) { \ | |||
There was a problem hiding this comment.
Use if (IS_ENABLED(DT_NODE_HAS_COMPAT_STATUS(DT_NODELABEL(rtwdog#nn), nxp_imx_rtwdog, okay)) here, instead of the runtime check.
Added the rtwdog Zephyr driver for RT1180 EVK.