ci: move twister to be pull_request base, integrate compliance #82457
Conversation
nashif
commented
Dec 3, 2024
nashif
commented
- ci: twister: convert to pull_request
- ci: compliance: convert compliance to workflow_call
|
Is this normal?
|
it's not, give it a force push. |
yes, the compliance workflow is gone now, the status of the twister workflow (we probably need to rename this to something else now) will be used for PRs, so we need to remove this from GH settings. |
Oh so it's not going to show as its own workflow anymore, but then it's not going to retrigger on PR message edits right? |
| @@ -1,15 +1,20 @@ | |||
| name: Compliance Checks | |||
|
|
|||
| on: | |||
| pull_request: | |||
| types: | |||
| - edited | |||
There was a problem hiding this comment.
I think this is going to break the "empty PR message" below, the check would fail and only rerun on push. It should probably be moved on a separate workflow.
There was a problem hiding this comment.
yeah i know and I am aware of that. I am thinking of moving this type of checks to somewhere else.
There was a problem hiding this comment.
@fabiobaltieri should be "fixed" now
fabiobaltieri
dismissed
their stale review
new comment about the empty message check
Convert twister workflow to use pull_request. Signed-off-by: Anas Nashif <[email protected]>
Add compliance to twister workflow as a the first step. If compliance fials, no twister will run. Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
topic/ci/pr_target
branch
from
8662b28
to
47f152c
Compare
Move PR body check to a workflow that monitors editing of PRs. Avoids rerunnin compliance check and other heavy weights workflows on just an edit of the PR body. Signed-off-by: Anas Nashif <[email protected]>
Add more functionality to the workflow, it is not only about not-merging anymore. Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
topic/ci/pr_target
branch
from
47f152c
to
f01751e
Compare
|
huh, it actually works here in the same PR, I did not expect that. Nice https://github.com/zephyrproject-rtos/zephyr/actions/runs/12149516128/job/33880348191?pr=82457 |
