boards: devicetree: replace 'zephyr,touch' chosen property with the 'touch' DT alias #89752
Conversation
github-actions
bot
requested review from
avisconti,
decsny,
DerekSnell,
djiatsaf-st,
dleach02,
EmilioCBen,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
jfischer-no,
kartben,
marwaiehm-st,
mathieuchopstm and
mmahadevan108
|
Hmm not sure about this one. I had in mind to add a feature inside of the gluecode to create a pointer input pseudo device, if a newly added Kconfig symbol This would allow us to remove the lvgl input pointer from intree dts. As much as I like LVGL (given I am maintaining our fork 🙃) I kinda dislike the fact the device trees contain the pseudo devices by default. In consequence this makes LVGL a non-optional module (kind of) and this feels wrong to me. |
Wouldn't that not work for multiple displays? :)
As stated here #86815 (comment), I believe there isn't another practical way around it for the time being.
I agree that's not ideal. |
JarmouniA
force-pushed
the
remove_zephyr_touch_chosen_prop
branch
from
9b435bf to
57e936f
Compare
'zephyr,touch' chosen property is currently used only by the subsys/input/draw_touch_events sample and not used by any upstream Zephyr driver, subsystem, or module. Hence it is not justified to have this chosen property as it only creates confusion and leads users to wrongly assume that setting this property produces some effect in Zephyr internals. Signed-off-by: Abderrahmane JARMOUNI <[email protected]>
JarmouniA
force-pushed
the
remove_zephyr_touch_chosen_prop
branch
from
57e936f to
3e11008
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
from DT perspective, if it's a test specific, it's true that alias makes more sense. but please @mmahadevan108 and display and video maintainers review to make sure this chosen property really isn't special as the PR claims, I don't know about this area personally |
It is not special, here is where it was added #77227, as a result of this comment #77227 (comment) |
zephyr,touchchosen property is currently used only by thesamples/subsys/input/draw_touch_eventsand not used by any in-tree driver, subsystem, or module.Hence, it is not justified to keep this chosen property as it only creates confusion and leads users to wrongly assume that setting it produces some effect in Zephyr internals.