modules: hal_silabs: Add config for SiSDK Protocol Crypto #97060
Conversation
zephyrbot
added
platform: Silabs
zephyrbot
requested review from
HaavardRei,
HoZHel,
Martinhoff-maker,
PavelVPV,
Thalley,
alwa-nordic,
asmellby,
cvinayak,
hermabe,
jerome-pouiller,
jhedberg,
rettichschnidi,
sjanc and
yonsch
| example, Bluetooth LE and a proprietary 2.4 GHz stack) on Gecko SoCs. | ||
|
|
||
| config SILABS_SISDK_PROTOCOL_CRYPTO | ||
| bool "Accelerated Crypto Primitives (RADIOAES)" |
There was a problem hiding this comment.
This should be a promptless symbol (no description text => hidden from config UI), since it's an internal API used by the BT controller and other protocols.
| depends on SOC_GECKO_HAS_RADIO | ||
| help | ||
| This component provides accelerated cryptographic primitives using the | ||
| RADIOAES (series-2) peripherals. |
There was a problem hiding this comment.
Add a sentence "This HAL library is used internally in wireless protocols, and can not be used directly." or something like that, or remove the help text completely since it's promptless.
There was a problem hiding this comment.
removed text for promptless Kconfig
db00lean
force-pushed
the
add_silabs_crypto_config
branch
from
1ad1c6f to
53a8f50
Compare
| example, Bluetooth LE and a proprietary 2.4 GHz stack) on Gecko SoCs. | ||
|
|
||
| config SILABS_SISDK_PROTOCOL_CRYPTO | ||
| bool "Accelerated Crypto Primitives - RADIOAES" |
There was a problem hiding this comment.
To get a promptless symbol, you have to remove the description after bool.
db00lean
force-pushed
the
add_silabs_crypto_config
branch
from
53a8f50 to
8a084ad
Compare
There was a problem hiding this comment.
Sorry, I didn't deeply looked at the dependencies:
depends on SOC_GECKO_HAS_RADIOshould be reported inBT_SILABS_EFR32(the issue was already here sinceSOC_GECKO_USE_RAIL) alsodepends on SOC_GECKO_HAS_RADIO(see https://docs.zephyrproject.org/latest/build/kconfig/tips.html#select-pitfalls)- I assume mbedtls is only required for
sl_protocol_crypto. Soselect MBEDTLS,MBEDTLS_PSA_CRYPTO_CandMBEDTLS_ENTROPY_Cshould be moved in theSILABS_SISDK_PROTOCOL_CRYPTOsymbol.
No. The protocol crypto does not use Mbed TLS, it's a dedicated engine that uses a low-level HAL called from inside the radio library. |
db00lean
force-pushed
the
add_silabs_crypto_config
branch
from
8a084ad to
7cf2e20
Compare
|
@db00lean you'll need to rebase this to fix a merge conflict |
A Kconfig options for the SiSDK Protocol Crypto library, which provides accelerated cryptographic primitives using the RADIOAES peripherals for Series-2 devices. Signed-off-by: David Boullie <[email protected]>
db00lean
force-pushed
the
add_silabs_crypto_config
branch
from
7cf2e20 to
0734c90
Compare
|
6 participants
A Kconfig options for the SiSDK Protocol Crypto library, which provides accelerated cryptographic primitives using the RADIOAES peripherals for Series-2 devices.