Skip to content

soc: nxp: mcux: Enable DMAMUX driver for S32Z270 #99190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

soc: nxp: mcux: Enable DMAMUX driver for S32Z270 #99190

wants to merge 1 commit into from
+48 −12

Conversation

@haduongquang
Copy link
Contributor

@haduongquang haduongquang commented Nov 11, 2025 •
edited
Loading

The S32Z270 uses DMAMUX instead of TRIGMUX.
Update the configuration to enable the DMAMUX driver

This fix #98168

test drivers.dma.chan_blen_transfer log:

------ TESTSUITE SUMMARY START ------

SUITE PASS - 100.00% [dma_m2m]: pass = 4, fail = 0, skip = 0, total = 4 duration = 8.061 seconds
 - PASS - [dma_m2m.test_tst_dma0_m2m_chan0_burst16] duration = 2.016 seconds
 - PASS - [dma_m2m.test_tst_dma0_m2m_chan0_burst8] duration = 2.015 seconds
 - PASS - [dma_m2m.test_tst_dma0_m2m_chan1_burst16] duration = 2.015 seconds
 - PASS - [dma_m2m.test_tst_dma0_m2m_chan1_burst8] duration = 2.015 seconds

test drivers.dma.loop_transfer log:

------ TESTSUITE SUMMARY START ------

SUITE PASS - 100.00% [dma_m2m_loop]: pass = 3, fail = 0, skip = 0, total = 3 duration = 1.103 seconds
 - PASS - [dma_m2m_loop.test_tst_dma0_m2m_loop] duration = 0.282 seconds
 - PASS - [dma_m2m_loop.test_tst_dma0_m2m_loop_repeated_start_stop] duration = 0.277 seconds
 - PASS - [dma_m2m_loop.test_tst_dma0_m2m_loop_suspend_resume] duration = 0.544 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION SUCCESSFUL

@zephyrbot zephyrbot added platform: NXP NXP size: XS A PR changing only a single line of code labels Nov 11, 2025
@manuargue manuargue self-assigned this Nov 11, 2025
manuargue
manuargue reviewed Nov 11, 2025
View reviewed changes
modules/hal_nxp/mcux/mcux-sdk-ng/drivers/drivers.cmake Outdated
endif()

if(${MCUX_DEVICE} MATCHES "S32K3")
if((${MCUX_DEVICE} MATCHES "S32K3") OR (${MCUX_DEVICE} MATCHES "S32Z"))
Copy link
Member

@manuargue manuargue Nov 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using:

Suggested change
if((${MCUX_DEVICE} MATCHES "S32K3") OR (${MCUX_DEVICE} MATCHES "S32Z"))
if(CONFIG_SOC_SERIES_S32K3 OR CONFIG_SOC_SERIES_S32ZE)

Copy link
Member

@manuargue manuargue Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't think this is the correct fix. For what I can see, dmamux is being enabled when DMA_MCUX_EDMA is selected, but because S32Z dma compat is version 3, DMA_MCUX_EDMA is not selected. It seems to be this should be addressed instead.

Copy link
Contributor Author

@haduongquang haduongquang Nov 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't think this is the correct fix. For what I can see, dmamux is being enabled when DMA_MCUX_EDMA is selected, but because S32Z dma compat is version 3, DMA_MCUX_EDMA is not selected. It seems to be this should be addressed instead.

Because the DMA on some other boards (such as the MCXW7X SoC, which introduced this issue) is also version 3 and using TRIGMUX instead of DMAMUX, I believe we cannot enable DMAMUX by default for all boards.

Copy link
Member

@manuargue manuargue Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, then to fix the issue we should decouple dma version of the mux type (dmamux, trgmux) so that all use-cases are supported

Copy link
Contributor Author

@haduongquang haduongquang Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To cover all use-cases are supported, I added new property to select the DMA type (DMAMUX, TRGMUX).
Additionally, two Kconfig options are introduced to conditionally enable the corresponding driver based on the selected DMA type.

@haduongquang haduongquang force-pushed the fix-dma-build-failure-for-s32z270 branch from f07a264 to b6f07b4 Compare November 11, 2025 10:04
@manuargue manuargue mentioned this pull request Nov 13, 2025
Open
@haduongquang
soc: nxp: mcux: Add DMAMUX support for S32Z270
7bf984b 
S32 SoCs use DMAMUX for DMA channel routing instead of TRGMUX.

Introduce a property to select the MUX type (DMAMUX, TRGMUX, or NONE)
and add corresponding Kconfig options to enable the appropriate driver
based on the selected type.

Signed-off-by: Ha Duong Quang <[email protected]>
@haduongquang haduongquang force-pushed the fix-dma-build-failure-for-s32z270 branch from b6f07b4 to 7bf984b Compare November 14, 2025 02:49
@zephyrbot zephyrbot requested review from butok and dbaluta November 14, 2025 02:51
@zephyrbot zephyrbot requested a review from DerekSnell November 14, 2025 02:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuargue manuargue manuargue left review comments

@axelnxp axelnxp Awaiting requested review from axelnxp

@bperseghetti bperseghetti Awaiting requested review from bperseghetti

@decsny decsny Awaiting requested review from decsny

@dleach02 dleach02 Awaiting requested review from dleach02

@EmilioCBen EmilioCBen Awaiting requested review from EmilioCBen

@JiafeiPan JiafeiPan Awaiting requested review from JiafeiPan

@MaochenWang1 MaochenWang1 Awaiting requested review from MaochenWang1

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@ZhaoxiangJin ZhaoxiangJin Awaiting requested review from ZhaoxiangJin

@butok butok Awaiting requested review from butok

@dbaluta dbaluta Awaiting requested review from dbaluta

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

At least 2 approving reviews are required to merge this pull request.

Assignees

@manuargue manuargue

@mmahadevan108 mmahadevan108

@dleach02 dleach02

Labels

area: Boards/SoCs area: Devicetree Bindings area: DMA Direct Memory Access platform: NXP MCU platform: NXP S32 NXP Semiconductors, S32 platform: NXP NXP size: XS A PR changing only a single line of code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tests: drivers: dma: dma_m2m_loop build failure fir NXP S32 platforms

6 participants

@haduongquang @manuargue @mmahadevan108 @zephyrbot @dleach02 @decsny