Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

#139 - added EthToWei conversion #140

Closed
wants to merge 2 commits into from

Conversation

abdulowork
Copy link
Contributor

As per #139

  • added an EthToWei to be able to convert a whole eth amount to a wei amount

@0crat
Copy link

0crat commented Jun 8, 2018

Job #140 is now in scope, role is REV

@codecov-io
Copy link

codecov-io commented Jun 8, 2018

Codecov Report

Merging #140 into develop will decrease coverage by 0.16%.
The diff coverage is 52.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #140      +/-   ##
===========================================
- Coverage    96.62%   96.46%   -0.17%     
===========================================
  Files          296      298       +2     
  Lines         9779     9815      +36     
===========================================
+ Hits          9449     9468      +19     
- Misses         330      347      +17
Impacted Files Coverage Δ
Example/Tests/NumberScalar/EthToWeiTests.swift 100% <100%> (ø)
Web3Swift/NumberScalar/EthToWei.swift 32% <32%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e8bbd...c690e9c. Read the comment docs.

Copy link
Member

@rockfridrich rockfridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create something like Eth, GWei, Wei, NoEther that can be converted to Wei, hex and Decimal and can be constructed from Wei and Decimal

@abdulowork
Copy link
Contributor Author

I think it might be a good idea to add si prefixes

@abdulowork
Copy link
Contributor Author

We also need a DoubleScalar such that you could create EthToWei(amount: 1.1)

@abdulowork
Copy link
Contributor Author

Lets do this one later

@abdulowork abdulowork closed this Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants