Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remove not present option in setup and bundle command #21

Closed
wants to merge 1 commit into from

Conversation

brandonguigo
Copy link

This is the addition of the remove flag mentioned inside the Pull Request #20

I have added to the setup and bundle command the option -r or --rm that adds to the brew bundle command the --cleanup and --zap option.

The option will be applied to each workspaces since it's passed to the ZeroRunner with a default value to false.

However, I still see an issue that can cause problems with workspaces : the --zap and --cleanup options are passed to each brew bundle commands, for each workspaces. When launching the first brew bundle command (on the shared workspace), it will remove all bottles and casks from other workspaces.

I see a possible solution but it will require a breaking change in the way we process Brewfiles : instead of launching the brew command inside a directory, we can collect the content of the Brewfiles for each workspace, append it to a single big Brewfile and bundle this. What do you think @msanders ?

@brandonguigo
Copy link
Author

Since I don't ad any response in more than 1 month, I've decided to fork this repo and make my own tool.

Here's the repo for a complete MaaC (Mac as a Code) tool : https://github.com/brandonguigo/usanidi ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant