Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.4 #59

Merged
merged 15 commits into from
Jun 8, 2024
Merged

1.20.4 #59

merged 15 commits into from
Jun 8, 2024

Conversation

nothub
Copy link
Contributor

@nothub nothub commented May 16, 2024

After updating to 1.20.4, some issues were present.

Resolved:

stats

First issue:

java.lang.NullPointerException: Cannot invoke "com.comphenix.protocol.wrappers.PlayerInfoData.getProfile()" because "data" is null

Full Trace:

[22:46:16 INFO]: UUID of player lit_furnace is 8be60c03-25c5-4e57-ab5d-0081e8736cf8
[22:46:16 ERROR]: [QueuePlugin] Unhandled exception occurred in onPacketSending(PacketEvent) for QueuePlugin
java.lang.NullPointerException: Cannot invoke "com.comphenix.protocol.wrappers.PlayerInfoData.getProfile()" because "data" is null
	at org.cloudanarchy.queueplugin.EventCanceler.lambda$onPacketSending$0(EventCanceler.java:60) ~[queueplugin-2.1.0+1.20.4-paper.jar:?]
	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:178) ~[?:?]
	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) ~[?:?]
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
	at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) ~[?:?]
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
	at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?]
	at org.cloudanarchy.queueplugin.EventCanceler.onPacketSending(EventCanceler.java:60) ~[queueplugin-2.1.0+1.20.4-paper.jar:?]
	at com.comphenix.protocol.injector.SortedPacketListenerList.invokeSendingListener(SortedPacketListenerList.java:219) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.SortedPacketListenerList.invokeUnpackedPacketSending(SortedPacketListenerList.java:204) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.SortedPacketListenerList.invokePacketSending(SortedPacketListenerList.java:149) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.SortedPacketListenerList.invokePacketSending(SortedPacketListenerList.java:139) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.PacketFilterManager.postPacketToListeners(PacketFilterManager.java:553) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.PacketFilterManager.invokePacketSending(PacketFilterManager.java:526) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.manager.NetworkManagerInjector.onPacketSending(NetworkManagerInjector.java:100) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.channel.NettyChannelInjector.processOutbound(NettyChannelInjector.java:553) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.channel.NettyChannelInjector$2.doProxyRunnable(NettyChannelInjector.java:456) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.channel.NettyEventLoopProxy.proxyRunnable(NettyEventLoopProxy.java:43) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.channel.NettyEventLoopProxy.execute(NettyEventLoopProxy.java:252) ~[ProtocolLib.jar:?]
	at net.minecraft.network.Connection.sendPacket(Connection.java:433) ~[?:?]
	at net.minecraft.network.Connection.send(Connection.java:393) ~[?:?]
	at net.minecraft.server.network.ServerCommonPacketListenerImpl.send(ServerCommonPacketListenerImpl.java:255) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.network.ServerCommonPacketListenerImpl.send(ServerCommonPacketListenerImpl.java:240) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.players.PlayerList.placeNewPlayer(PlayerList.java:370) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.network.ServerConfigurationPacketListenerImpl.handleConfigurationFinished(ServerConfigurationPacketListenerImpl.java:134) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.network.protocol.configuration.ServerboundFinishConfigurationPacket.handle(ServerboundFinishConfigurationPacket.java:18) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.network.protocol.configuration.ServerboundFinishConfigurationPacket.a(ServerboundFinishConfigurationPacket.java:9) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:54) ~[?:?]
	at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:149) ~[?:?]
	at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?]
	at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1465) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:194) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:123) ~[?:?]
	at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1442) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1365) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:133) ~[?:?]
	at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1343) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1232) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[paper-1.20.4.jar:git-Paper-496]
	at java.lang.Thread.run(Thread.java:840) ~[?:?]
[22:46:16 ERROR]: Parameters: 
  net.minecraft.network.protocol.game.ClientboundPlayerInfoUpdatePacket@377ef49b[
    a=[ADD_PLAYER, INITIALIZE_CHAT, UPDATE_GAME_MODE, UPDATE_LISTED, UPDATE_LATENCY, UPDATE_DISPLAY_NAME]
    b=[b[profileId=8be60c03-25c5-4e57-ab5d-0081e8736cf8, profile=com.mojang.authlib.GameProfile@76ce1784[id=8be60c03-25c5-4e57-ab5d-0081e8736cf8,name=lit_furnace,properties={textures=[Property[name=textures, value=ewogICJ0aW1lc3RhbXAiIDogMTcxNTU0Njc3NjA2OCwKICAicHJvZmlsZUlkIiA6ICI4YmU2MGMwMzI1YzU0ZTU3YWI1ZDAwODFlODczNmNmOCIsCiAgInByb2ZpbGVOYW1lIiA6ICJsaXRfZnVybmFjZSIsCiAgInNpZ25hdHVyZVJlcXVpcmVkIiA6IHRydWUsCiAgInRleHR1cmVzIiA6IHsKICAgICJTS0lOIiA6IHsKICAgICAgInVybCIgOiAiaHR0cDovL3RleHR1cmVzLm1pbmVjcmFmdC5uZXQvdGV4dHVyZS8zMjE3ODkwMTU2MDUwOTYxYWYzNDE3ZmEzMWIzNTI1NmQ1ODY3Zjk0ODZjZjA5YWQyMmFlNTVlZDhmYTJkYWExIgogICAgfSwKICAgICJDQVBFIiA6IHsKICAgICAgInVybCIgOiAiaHR0cDovL3RleHR1cmVzLm1pbmVjcmFmdC5uZXQvdGV4dHVyZS8yMzQwYzBlMDNkZDI0YTExYjE1YThiMzNjMmE3ZTllMzJhYmIyMDUxYjI0ODFkMGJhN2RlZmQ2MzVjYTdhOTMzIgogICAgfQogIH0KfQ==, signature=vre8n0BOWCOpf+3mNsMNMrLQWzKsfvhmVa/YkUnQb95bGlvrVvAfZLZCWqe1mAqpQXVACfLT3v/Uj6W24s29e27M/NdLHzyxYjyU4wy5UNQy8DNwy5PK9Q/NFl4MUxZ/gX9qM1Z0vtaRpEDquLF4GhRvT0V/R7XeX+jxxdeKwGui5MG7wY0XgXlUUJsw0iie6sS/t5fysxbjF6PU/2aVKgoJGZKHHQz6o0rQ4TCCW2iOF2c9b5Ko8M9GsHSU4jRl/0d6C8dugy+x7U3LwG8JeObMHUjJbAIhPTtf2kytUL+TyUfIBsdwcevzaanJgwTNAEuJCnY9LbAamEyFWDt3VcdkD5igKz8tcaxax19V0rHV00Eb3UUy+isvL3OZ+TFMKy7qexz+btsHD8TC5KiM11n/kSO34J9LA9Ihk0yqc+EKK4YynzY2JGKQt6emczP3l+BFYlVjynMqD5x7Zax9cJ6wyhzDtSFh2+Gmm1uCWh4ZOAww+IAW4oLG9rnYbW26xYvmkfBuupoLJ7EDjPwNTVR4FZv2W3uYcDpGdT02f+5ig4oHJ+Hz7954NTDzFiLpCD/Ub6j4/LdBnm7mtZQ4rgIuTFJzFVMZYahHQIGeSqvv1RN3xkrCahErD8k0sE6Wu7Zc6V2nFkE/NaF9l/SZqYSZleujyNAeI975B3k3c9w=]]}], listed=true, latency=0, gameMode=SPECTATOR, displayName=null, chatSession=null]]
  ]

[22:46:16 INFO]: lit_furnace[/127.0.0.1:46124] logged in with entity id 72 at ([world]0.0, 140.0, 0.0)

Patch for above issue:

Index: src/main/java/org/cloudanarchy/queueplugin/EventCanceler.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/main/java/org/cloudanarchy/queueplugin/EventCanceler.java b/src/main/java/org/cloudanarchy/queueplugin/EventCanceler.java
--- a/src/main/java/org/cloudanarchy/queueplugin/EventCanceler.java	(revision f849d8c05a571bf727cc8e5b97a835639f9d46b0)
+++ b/src/main/java/org/cloudanarchy/queueplugin/EventCanceler.java	(date 1715546887145)
@@ -13,6 +13,7 @@
 import org.cloudanarchy.queueplugin.packetwrapper.PacketPlayerInfo;
 
 import java.util.HashSet;
+import java.util.Objects;
 import java.util.Set;
 import java.util.stream.Collectors;
 
@@ -57,7 +58,7 @@
             PacketPlayerInfo packet = new PacketPlayerInfo(ev.getPacket());
             // send players only their own data? or don't send this packet at all...
             if (packet.getData() != null)
-                packet.setData(packet.getData().stream().filter(data -> data.getProfile().getUUID().equals(ev.getPlayer().getUniqueId())).collect(Collectors.toList()));
+                packet.setData(packet.getData().stream().filter(Objects::nonNull).filter(data -> data.getProfile().getUUID().equals(ev.getPlayer().getUniqueId())).collect(Collectors.toList()));
             return;
         }

Second issue:

java.lang.IllegalStateException: Unable to set value of field private final java.util.EnumSet

[22:50:22 INFO]: UUID of player lit_furnace is 8be60c03-25c5-4e57-ab5d-0081e8736cf8
[22:50:22 ERROR]: [QueuePlugin] Unhandled exception occurred in onPacketSending(PacketEvent) for QueuePlugin
java.lang.IllegalStateException: Unable to set value of field private final java.util.EnumSet net.minecraft.network.protocol.game.ClientboundPlayerInfoUpdatePacket.a
	at com.comphenix.protocol.reflect.accessors.DefaultFieldAccessor.set(DefaultFieldAccessor.java:44) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.reflect.StructureModifier.writeInternal(StructureModifier.java:358) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.reflect.StructureModifier.write(StructureModifier.java:321) ~[ProtocolLib.jar:?]
	at org.cloudanarchy.queueplugin.packetwrapper.PacketPlayerInfo.setData(PacketPlayerInfo.java:54) ~[queueplugin-2.1.0+1.20.4-paper.jar:?]
	at org.cloudanarchy.queueplugin.EventCanceler.onPacketSending(EventCanceler.java:61) ~[queueplugin-2.1.0+1.20.4-paper.jar:?]
	at com.comphenix.protocol.injector.SortedPacketListenerList.invokeSendingListener(SortedPacketListenerList.java:219) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.SortedPacketListenerList.invokeUnpackedPacketSending(SortedPacketListenerList.java:204) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.SortedPacketListenerList.invokePacketSending(SortedPacketListenerList.java:149) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.SortedPacketListenerList.invokePacketSending(SortedPacketListenerList.java:139) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.PacketFilterManager.postPacketToListeners(PacketFilterManager.java:553) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.PacketFilterManager.invokePacketSending(PacketFilterManager.java:526) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.manager.NetworkManagerInjector.onPacketSending(NetworkManagerInjector.java:100) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.channel.NettyChannelInjector.processOutbound(NettyChannelInjector.java:553) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.channel.NettyChannelInjector$2.doProxyRunnable(NettyChannelInjector.java:456) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.channel.NettyEventLoopProxy.proxyRunnable(NettyEventLoopProxy.java:43) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.channel.NettyEventLoopProxy.execute(NettyEventLoopProxy.java:252) ~[ProtocolLib.jar:?]
	at net.minecraft.network.Connection.sendPacket(Connection.java:433) ~[?:?]
	at net.minecraft.network.Connection.send(Connection.java:393) ~[?:?]
	at net.minecraft.server.network.ServerCommonPacketListenerImpl.send(ServerCommonPacketListenerImpl.java:255) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.network.ServerCommonPacketListenerImpl.send(ServerCommonPacketListenerImpl.java:240) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.players.PlayerList.placeNewPlayer(PlayerList.java:370) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.network.ServerConfigurationPacketListenerImpl.handleConfigurationFinished(ServerConfigurationPacketListenerImpl.java:134) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.network.protocol.configuration.ServerboundFinishConfigurationPacket.handle(ServerboundFinishConfigurationPacket.java:18) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.network.protocol.configuration.ServerboundFinishConfigurationPacket.a(ServerboundFinishConfigurationPacket.java:9) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:54) ~[?:?]
	at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:149) ~[?:?]
	at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?]
	at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1465) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:194) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:123) ~[?:?]
	at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1442) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1365) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:112) ~[?:?]
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1557) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1226) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[paper-1.20.4.jar:git-Paper-496]
	at java.lang.Thread.run(Thread.java:840) ~[?:?]
Caused by: java.lang.ClassCastException: Cannot cast java.util.ArrayList to java.util.EnumSet
	at java.lang.Class.cast(Class.java:3889) ~[?:?]
	at com.comphenix.protocol.reflect.accessors.DefaultFieldAccessor.set(DefaultFieldAccessor.java:41) ~[ProtocolLib.jar:?]
	... 37 more
[22:50:22 ERROR]: Parameters: 
  net.minecraft.network.protocol.game.ClientboundPlayerInfoUpdatePacket@468a6f8c[
    a=[ADD_PLAYER, INITIALIZE_CHAT, UPDATE_GAME_MODE, UPDATE_LISTED, UPDATE_LATENCY, UPDATE_DISPLAY_NAME]
    b=[b[profileId=8be60c03-25c5-4e57-ab5d-0081e8736cf8, profile=com.mojang.authlib.GameProfile@1d83baad[id=8be60c03-25c5-4e57-ab5d-0081e8736cf8,name=lit_furnace,properties={textures=[Property[name=textures, value=ewogICJ0aW1lc3RhbXAiIDogMTcxNTU0NzAyMTk0NiwKICAicHJvZmlsZUlkIiA6ICI4YmU2MGMwMzI1YzU0ZTU3YWI1ZDAwODFlODczNmNmOCIsCiAgInByb2ZpbGVOYW1lIiA6ICJsaXRfZnVybmFjZSIsCiAgInNpZ25hdHVyZVJlcXVpcmVkIiA6IHRydWUsCiAgInRleHR1cmVzIiA6IHsKICAgICJTS0lOIiA6IHsKICAgICAgInVybCIgOiAiaHR0cDovL3RleHR1cmVzLm1pbmVjcmFmdC5uZXQvdGV4dHVyZS8zMjE3ODkwMTU2MDUwOTYxYWYzNDE3ZmEzMWIzNTI1NmQ1ODY3Zjk0ODZjZjA5YWQyMmFlNTVlZDhmYTJkYWExIgogICAgfSwKICAgICJDQVBFIiA6IHsKICAgICAgInVybCIgOiAiaHR0cDovL3RleHR1cmVzLm1pbmVjcmFmdC5uZXQvdGV4dHVyZS8yMzQwYzBlMDNkZDI0YTExYjE1YThiMzNjMmE3ZTllMzJhYmIyMDUxYjI0ODFkMGJhN2RlZmQ2MzVjYTdhOTMzIgogICAgfQogIH0KfQ==, signature=Hwl6cCiBZG/DqhSoaIh+K364tOOqdC1/Bn3bZe0aOpTj3CluPckBQFMp0a3UN70p/ZY6uxlUP3PYyEWM6jnfajfvRYmMHYfumDmCu4XSAl+ljxy3ju37HiFQbkY5k7v0wwrhGWZXcXwDQveXLvpYTquexv9GYzxhWVndgTq4CZ2iW8e/s6cnjZxxUvFevzxOTwycFgzA/tDdAXhWLYH91Zhd9pz6YfryS1lvzfu2/vR31Ih3CAwytB89LKp+oPU/XvXGygt8CQx1m5AZyh6NApcb4gTmbtx9hOEh8p5dAMvqZJyK7VISWcKXjUhcmqQIAewU5OvL5/dpxYha/RqxLvaUPZQIBv3HP8vBMNlKy+YanUFvxSYgWnaGMlkMalpD7hY/j9iwwuuwzeZaW9Ruh0ELRZbp01bafV97IkW/295Hdok17qgWj8QIZe5NgmRyIL+S1446gy43bjx9ItCcBkOQwiLUTpxJC/TYtB42EplyCfDd5vGWcJpId0gfXTVHFYvKhTCpxmDAn1VD5yPv9iUdGT9S6hzgh+6gSxslfxKVyDcBC2bWgJg+eJRS6STphwy4llpWjq+zASDhdfDB4Ca/syx2BPj63zFbtNuQkvxeVjiyQwq5zZvXQxEd96C5yPi4aHde/bFXlTNVgJ06NvEVTqaUxVZVqZvaSle5wyQ=]]}], listed=true, latency=0, gameMode=SPECTATOR, displayName=null, chatSession=null]]
  ]

[22:50:22 INFO]: lit_furnace[/127.0.0.1:32928] logged in with entity id 88 at ([world]0.0, 140.0, 0.0)
[22:50:47 ERROR]: [QueuePlugin] Unhandled exception occurred in onPacketSending(PacketEvent) for QueuePlugin
java.lang.IllegalStateException: Unable to set value of field private final java.util.EnumSet net.minecraft.network.protocol.game.ClientboundPlayerInfoUpdatePacket.a
	at com.comphenix.protocol.reflect.accessors.DefaultFieldAccessor.set(DefaultFieldAccessor.java:44) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.reflect.StructureModifier.writeInternal(StructureModifier.java:358) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.reflect.StructureModifier.write(StructureModifier.java:321) ~[ProtocolLib.jar:?]
	at org.cloudanarchy.queueplugin.packetwrapper.PacketPlayerInfo.setData(PacketPlayerInfo.java:54) ~[queueplugin-2.1.0+1.20.4-paper.jar:?]
	at org.cloudanarchy.queueplugin.EventCanceler.onPacketSending(EventCanceler.java:61) ~[queueplugin-2.1.0+1.20.4-paper.jar:?]
	at com.comphenix.protocol.injector.SortedPacketListenerList.invokeSendingListener(SortedPacketListenerList.java:219) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.SortedPacketListenerList.invokeUnpackedPacketSending(SortedPacketListenerList.java:204) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.SortedPacketListenerList.invokePacketSending(SortedPacketListenerList.java:149) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.SortedPacketListenerList.invokePacketSending(SortedPacketListenerList.java:139) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.PacketFilterManager.postPacketToListeners(PacketFilterManager.java:553) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.PacketFilterManager.invokePacketSending(PacketFilterManager.java:526) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.manager.NetworkManagerInjector.onPacketSending(NetworkManagerInjector.java:100) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.channel.NettyChannelInjector.processOutbound(NettyChannelInjector.java:553) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.channel.NettyChannelInjector$2.doProxyRunnable(NettyChannelInjector.java:456) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.channel.NettyEventLoopProxy.proxyRunnable(NettyEventLoopProxy.java:43) ~[ProtocolLib.jar:?]
	at com.comphenix.protocol.injector.netty.channel.NettyEventLoopProxy.execute(NettyEventLoopProxy.java:252) ~[ProtocolLib.jar:?]
	at net.minecraft.network.Connection.sendPacket(Connection.java:433) ~[?:?]
	at net.minecraft.network.Connection.send(Connection.java:393) ~[?:?]
	at net.minecraft.server.network.ServerCommonPacketListenerImpl.send(ServerCommonPacketListenerImpl.java:255) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.network.ServerCommonPacketListenerImpl.send(ServerCommonPacketListenerImpl.java:240) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.players.PlayerList.tick(PlayerList.java:1024) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1750) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:447) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1525) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1226) ~[paper-1.20.4.jar:git-Paper-496]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[paper-1.20.4.jar:git-Paper-496]
	at java.lang.Thread.run(Thread.java:840) ~[?:?]
Caused by: java.lang.ClassCastException: Cannot cast java.util.ArrayList to java.util.EnumSet
	at java.lang.Class.cast(Class.java:3889) ~[?:?]
	at com.comphenix.protocol.reflect.accessors.DefaultFieldAccessor.set(DefaultFieldAccessor.java:41) ~[ProtocolLib.jar:?]
	... 26 more
[22:50:47 ERROR]: Parameters: 
  net.minecraft.network.protocol.game.ClientboundPlayerInfoUpdatePacket@6366bef4[
    a=[UPDATE_LATENCY]
    b=[b[profileId=8be60c03-25c5-4e57-ab5d-0081e8736cf8, profile=com.mojang.authlib.GameProfile@1d83baad[id=8be60c03-25c5-4e57-ab5d-0081e8736cf8,name=lit_furnace,properties={textures=[Property[name=textures, value=ewogICJ0aW1lc3RhbXAiIDogMTcxNTU0NzAyMTk0NiwKICAicHJvZmlsZUlkIiA6ICI4YmU2MGMwMzI1YzU0ZTU3YWI1ZDAwODFlODczNmNmOCIsCiAgInByb2ZpbGVOYW1lIiA6ICJsaXRfZnVybmFjZSIsCiAgInNpZ25hdHVyZVJlcXVpcmVkIiA6IHRydWUsCiAgInRleHR1cmVzIiA6IHsKICAgICJTS0lOIiA6IHsKICAgICAgInVybCIgOiAiaHR0cDovL3RleHR1cmVzLm1pbmVjcmFmdC5uZXQvdGV4dHVyZS8zMjE3ODkwMTU2MDUwOTYxYWYzNDE3ZmEzMWIzNTI1NmQ1ODY3Zjk0ODZjZjA5YWQyMmFlNTVlZDhmYTJkYWExIgogICAgfSwKICAgICJDQVBFIiA6IHsKICAgICAgInVybCIgOiAiaHR0cDovL3RleHR1cmVzLm1pbmVjcmFmdC5uZXQvdGV4dHVyZS8yMzQwYzBlMDNkZDI0YTExYjE1YThiMzNjMmE3ZTllMzJhYmIyMDUxYjI0ODFkMGJhN2RlZmQ2MzVjYTdhOTMzIgogICAgfQogIH0KfQ==, signature=Hwl6cCiBZG/DqhSoaIh+K364tOOqdC1/Bn3bZe0aOpTj3CluPckBQFMp0a3UN70p/ZY6uxlUP3PYyEWM6jnfajfvRYmMHYfumDmCu4XSAl+ljxy3ju37HiFQbkY5k7v0wwrhGWZXcXwDQveXLvpYTquexv9GYzxhWVndgTq4CZ2iW8e/s6cnjZxxUvFevzxOTwycFgzA/tDdAXhWLYH91Zhd9pz6YfryS1lvzfu2/vR31Ih3CAwytB89LKp+oPU/XvXGygt8CQx1m5AZyh6NApcb4gTmbtx9hOEh8p5dAMvqZJyK7VISWcKXjUhcmqQIAewU5OvL5/dpxYha/RqxLvaUPZQIBv3HP8vBMNlKy+YanUFvxSYgWnaGMlkMalpD7hY/j9iwwuuwzeZaW9Ruh0ELRZbp01bafV97IkW/295Hdok17qgWj8QIZe5NgmRyIL+S1446gy43bjx9ItCcBkOQwiLUTpxJC/TYtB42EplyCfDd5vGWcJpId0gfXTVHFYvKhTCpxmDAn1VD5yPv9iUdGT9S6hzgh+6gSxslfxKVyDcBC2bWgJg+eJRS6STphwy4llpWjq+zASDhdfDB4Ca/syx2BPj63zFbtNuQkvxeVjiyQwq5zZvXQxEd96C5yPi4aHde/bFXlTNVgJ06NvEVTqaUxVZVqZvaSle5wyQ=]]}], listed=true, latency=0, gameMode=SPECTATOR, displayName=null, chatSession=null]]
  ]

Current issue:

Client times out even tho keep-alive packets (in/out) are allowed.

[00:50:27 INFO]: UUID of player CPacketAnimation is 88e9bdda-4c80-4899-a68b-9635ad8e1f07
[00:50:28 INFO]: CPacketAnimation[/127.0.0.1:48732] logged in with entity id 151 at ([world]0.0, 140.0, 0.0)
[00:51:15 WARN]: CPacketAnimation was kicked due to keepalive timeout!
[00:51:15 INFO]: CPacketAnimation lost connection: Timed out

Fixed by using a newer protolib plugin release 😩

Someone wanna check the changes i made?

An overview:

  • update to mc 1.20.4
  • gradle build system with xyz.jpenilla.run-paper plugin for runServer task
  • cleanup and update ci setup, also normalize (use same structure and actions as in the other repos)
  • use protolibs new integrated packet wrappers

(this pr was recreated from #49 because github failed to update the pr on branch-namechange)

@nothub nothub merged commit 84266c0 into master Jun 8, 2024
2 checks passed
@nothub nothub deleted the 1.20.4 branch June 8, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants