fix a warning:

src/ds1302.c:123: warning 158: overflow in implicit constant conversion
zerog2k · Feb 3, 2022 · 3579dc2 · 3579dc2
1 parent beb3b51
commit 3579dc2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/ds1302.c b/src/ds1302.c
@@ -120,7 +120,7 @@ uint8_t ds_readbyte(uint8_t addr) {
 void ds_readburst() {
     // ds1302 burst-read 8 bytes into struct
     uint8_t j, b;
-    b = DS_CMD | DS_CMD_CLOCK | DS_BURST_MODE << 1 | DS_CMD_READ;
+    b = DS_CMD | DS_CMD_CLOCK | (DS_BURST_MODE << 1) | DS_CMD_READ;
     DS_CE = 0;
     DS_SCLK = 0;
     DS_CE = 1;

diff --git a/src/ds1302.h b/src/ds1302.h
@@ -8,11 +8,11 @@
 
 #define _nop_ __asm nop __endasm;
 
-#define DS_CMD        1 << 7
-#define DS_CMD_READ   1
+#define DS_CMD        (1u << 7)
+#define DS_CMD_READ   1u
 #define DS_CMD_WRITE  0
 #define DS_CMD_RAM    1 << 6
-#define DS_CMD_CLOCK  0 << 6
+#define DS_CMD_CLOCK  (0u << 6)
 
 #define DS_ADDR_SECONDS     0
 #define DS_ADDR_MINUTES     1
@@ -34,7 +34,7 @@
 #define DS_TC_D2_4KO 0b1010
 #define DS_TC_D2_8KO 0b1011
 
-#define DS_BURST_MODE       31
+#define DS_BURST_MODE       31u
 
 // DS_ADDR_SECONDS	c111_1111	0_0-5_9 c=clock_halt
 // DS_ADDR_MINUTES	x111_1111	0_0-5_9