Add duration template for all function using std::chrono::milliseconds

[cacharle]

Makes the bindings slightly easier to use when dealing with durations. With the bindings handling the cast instead of the user

[coveralls]

Pull Request Test Coverage Report for Build 18631924080

Details

• 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.05%) to 88.424%

---

Totals
Change from base Build 17909983277:	0.05%
Covered Lines:	909
Relevant Lines:	1028

---

💛 - Coveralls

[cacharle]

Not sure how to unit test this properly..

Is there a "check if compiles" kind of unit tests for catch2?

[gummif]

check_event() is ambiguous

[gummif]

One concern is that for poll and poller, -1 millisecond is a special value that may need special handling. E.g. does -1s or -1ns do the right thing?

If the value of timeout is -1, zmq_poll() shall block indefinitely until a requested event has occurred on at least one zmq_pollitem_t.

[cacharle]

Negative duration work:

#include <print>
#include <optional>
#include <chrono>

int main()
{
    std::chrono::milliseconds ms{-1};
    std::println("{}", ms);
    std::println("{}", ms.count());

    std::chrono::nanoseconds ns{-1};
    std::println("{}", ns);
    std::println("{}", ns.count());
    return 0;
}

Output:

$ g++ -std=c++23 temp.cpp && ./a.out
-1ms
-1
-1ns
-1

[cacharle]

With c++17:

int main()
{
    std::chrono::milliseconds ms{-1};
    // std::cout << ms << '\n';
    std::cout << ms.count() << '\n';

    std::chrono::nanoseconds ns{-1};
    // std::cout << ns << '\n';
    std::cout << ns.count() << '\n';
    return 0;
}

Output:

$ g++ -std=c++17 temp.cpp && ./a.out
-1
-1

[gummif]

Yes, but you cast the input Duration to milliseconds then pass that to libzmq.

[cacharle]

Indeed, casting from -1ns to ms give 0ms, I'll change that

[gummif]

To check if something compiles or not you could use C++20/23 and concept or requires expressions.