Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates actions/upload-artifact to v4 #167

Merged
merged 3 commits into from
Dec 9, 2024
Merged

updates actions/upload-artifact to v4 #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
325808f
to upload-artifactv4
Dec 9, 2024
3f90361
download-artifact-v4
Dec 9, 2024
e434f79
testing different python versions
Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
pip install build
python -m build --sdist .
- name: Upload source package
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: distribution
path: dist/
Expand All @@ -31,7 +31,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Download source package
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
name: distribution
path: dist/
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
pip install build
python -m build --sdist .
- name: Upload source package
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: distribution
path: dist/
Expand All @@ -33,15 +33,15 @@ jobs:
max-parallel: 1 # tests interfere with each other if run in parallel
matrix:
# order matters - this setup minimizes the interference between jobs
python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9]
python-version: [3.8, 3.9]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python 2.7 is no longer supported actions/setup-python#672
3.5, 3.6, and 3.7 only use more specific version like x.y.z and do not have mac arm64 versions
proposing to simply delete them but happy to find an alternative based on preferences

os: [ubuntu-latest, windows-latest, macOS-latest]
steps:
- uses: actions/checkout@v1
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
with:
name: distribution
path: dist/
Expand Down
Loading