Report os arch #2320
Merged
Report os arch #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glimberg
reviewed
Jun 25, 2024
node/Constants.hpp
Outdated
Comment on lines
224
to
232
| #elif defined(__APPLE__) && defined(__MACH__) // Apple OSX and iOS (Darwin) | ||
| #include <TargetConditionals.h> | ||
| #if TARGET_IPHONE_SIMULATOR == 1 | ||
| #define ZT_PLATFORM_NAME "ios" // Apple iOS | ||
| #elif TARGET_OS_IPHONE == 1 | ||
| #define ZT_PLATFORM_NAME "ios" // Apple iOS | ||
| #elif TARGET_OS_MAC == 1 | ||
| #define ZT_PLATFORM_NAME "macos" // Apple OSX | ||
| #endif |
There was a problem hiding this comment.
I believe iPadOS is a separate thing now. We can probably detect that
glimberg
approved these changes
Sep 9, 2024
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds reporting of
OS/archto network controllers for some fairly innocuous metrics that will help with security checking and can be usefully shown to users.Also contains some commits that were un-done from another branch; ignore these. Only relevant files have changed.
Also added a
.clangdfor clang code-insight on the Zed editor among others.