Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using importlib instead of pkg_resources for version handling #447

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

reinout
Copy link
Collaborator

@reinout reinout commented Apr 18, 2024

No description provided.

@reinout
Copy link
Collaborator Author

reinout commented Apr 18, 2024

I think there's some docstring output thingy going wrong again. Perhaps the "detached HEAD" message has gotten a bit bigger in git? When comparing the output I don't really discover anything that's wrong except that the <BLANKLINE> discovery seems to discover the wrong blank lines in some cases.

@mauritsvanrees, I don't know if you're seeing something that's obviously wrong?

@mauritsvanrees
Copy link
Member

I think the links about writing bdist wheel are extra.

Showing first few lines...
running bdist_wheel
running build
running build_py
creating build
creating build/lib
...
Showing last few lines...
adding 'tha.example-0.1.dist-info/WHEEL'
adding 'tha.example-0.1.dist-info/top_level.txt'
adding 'tha.example-0.1.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
<BLANKLINE>

@reinout
Copy link
Collaborator Author

reinout commented Jun 16, 2024

Yeah, with the test fix from @mauritsvanrees , my PR also works :-) I'm merging it.

@mauritsvanrees : I assume we can do a new release now? I merged your branch as I suspected it was ready, but for safety's sake I'm keeping my finger away from the fullrelease <enter> until you give a ping :-)

@reinout reinout merged commit ee9a19e into master Jun 16, 2024
6 checks passed
@reinout reinout deleted the reinout-version-handling branch June 16, 2024 17:15
@mauritsvanrees
Copy link
Member

Yes, a release is fine.

Greetings from the Buschenschanksprint in Austria!

@reinout
Copy link
Collaborator Author

reinout commented Jun 16, 2024

Buschenschanksprint... Looks nice :-)
Last week I passed by Innsbruck/Brennerpass (by train, of course) on my way to Napoli, so I was a little bit in the neighbourhood.

@reinout
Copy link
Collaborator Author

reinout commented Jun 16, 2024

Release (9.2.0) done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants