Universal NFT: added testnet example #537
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThis pull request introduces a comprehensive "Demo on Testnet" section in the NFT documentation for developers. The new content provides detailed, step-by-step instructions for deploying, connecting, and transferring Universal NFT contracts across ZetaChain and EVM-compatible networks. The documentation includes practical Hardhat commands with example JSON outputs, guiding developers through the process of contract deployment, minting, and cross-chain transfers. Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/pages/developers/standards/nft.mdx (4)
435-481: Consider enhancing the deployment documentation.The deployment commands could benefit from the following improvements:
- Extract common parameters like gateway addresses into environment variables to follow DRY principles.
- Add comments explaining the significance of specific addresses (e.g., uniswap-router, gateway).
+# Set common parameters +GATEWAY_ADDRESS="0x0c487a766110c85d301d96e33579c5b317fa4995" +UNISWAP_ROUTER="0x2ca7d64A7EFE2D62A725E2B35Cf7230D6677FfEe" + npx hardhat nft:deploy \ --network zeta_testnet \ - --uniswap-router 0x2ca7d64A7EFE2D62A725E2B35Cf7230D6677FfEe \ + --uniswap-router $UNISWAP_ROUTER \ # Router for token swaps on ZetaChain --name ZetaChainUniversalNFT \ --json
483-551: Enhance the contract connection documentation.The connection process would be clearer with:
- A table mapping ZRC20 addresses to their respective chains.
- A diagram showing the connection flow between contracts.
- Explanation of why specific ZRC20 addresses are used.
553-574: Improve the minting example documentation.Consider the following enhancements:
- Use a realistic IPFS URI example instead of
https://example.org.- Explain the token ID generation mechanism (shown in output as
1133890395085443587238793966499147269485704287551).- Add a note about best practices for token URI storage.
575-638: Clarify the transfer process documentation.The transfer examples would benefit from:
- Explanation of gas amount differences between networks (5 ZETA vs 0.005 ETH).
- A table mapping destination ZRC20 addresses to their networks.
- Guidelines for estimating appropriate gas amounts.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/pages/developers/standards/nft.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build
- GitHub Check: Analyze (javascript)
|
@zeta-chain/fullstack please, review. |
1 similar comment
|
@zeta-chain/fullstack please, review. |
|
Thank) |
An example on how to deploy contracts, mint and transfer universal NFTs on testnet.
Summary by CodeRabbit