Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove simapp imports #83

Merged
merged 3 commits into from
Jul 24, 2024
Merged

chore: remove simapp imports #83

merged 3 commits into from
Jul 24, 2024

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Jul 23, 2024 •
edited
Loading

Remove simapp imports so node is importable: zeta-chain/node#2498

https://docs.cosmos.network/main/build/migrations/upgrading#simapp-2

Mostly a manual port of crypto-org-chain/ethermint#411

Currently based on #82 so CI works

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 23, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gartnera gartnera force-pushed the remove-simapp-imports branch from 704d476 to a8efba4 Compare July 23, 2024 18:25
@gartnera gartnera marked this pull request as ready for review July 23, 2024 18:34
@gartnera gartnera requested review from lumtis, skosito and fbac July 23, 2024 18:35
@fbac
Copy link
Contributor

fbac commented Jul 24, 2024

I'd like to see for our own ethermint fork that we don't rely on evmos/ethermint as a dependency, instead we could port changes and depend on ourselves.

lumtis
lumtis approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

skosito
skosito approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just minor questions

app/app.go
@@ -338,9 +339,11 @@ func NewEthermintApp(
os.Exit(1)
}

invCheckPeriod := cast.ToUint(appOpts.Get(server.FlagInvCheckPeriod))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change related to simapp import? should we change something in configuration to read this instead of hardcoding to 5 as it was before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not specifically, but it was part of the same change from crypto-org-chain/ethermint

encoding/config.go Show resolved Hide resolved
types/encoding.go
"github.com/cosmos/cosmos-sdk/codec/types"
)

// EncodingConfig specifies the concrete encoding types to use for a given app.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change needed for simapp import?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is needed because it basically just copies the structure out of simapp. You can see the ethermint.EncodingConfig.

It's imported in encoding/config.go

@fbac fbac mentioned this pull request Jul 24, 2024
Closed
Base automatically changed from fix-nix-build to main July 24, 2024 14:42
@fbac fbac merged commit adf8e70 into main Jul 24, 2024
16 of 17 checks passed
@fbac fbac deleted the remove-simapp-imports branch July 24, 2024 16:04
@fbac
Copy link
Contributor

fbac commented Jul 24, 2024

Merging this to unblock #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbac fbac fbac left review comments

@skosito skosito skosito approved these changes

@lumtis lumtis lumtis approved these changes

Assignees
No one assigned
Labels
C:Encoding C:Types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gartnera @fbac @lumtis @skosito