Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependencies should not point to upstream #87

Merged
merged 8 commits into from
Jul 25, 2024
Merged

Conversation

fbac
Copy link
Contributor

@fbac fbac commented Jul 25, 2024

Changes

Closes #85
The "fix" is just a replacing all evmos/ethermint for zeta-chain/ethermint.

Failures

  • protobuf breaking check workflows fails because it check the current changes against the PR base branch. It's expected for it to fail on this case.
      - uses: bufbuild/buf-breaking-action@v1
        with:
          input: "proto"
          against: "https://github.com/${{ github.repository }}.git#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto"

Copy link

coderabbitai bot commented Jul 25, 2024

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

228 files out of 286 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -1,4 +1,4 @@
module github.com/evmos/ethermint
module github.com/zeta-chain/ethermint

Check notice

Code scanning / govulncheck

[GO-2022-0646] Use of risky cryptographic algorithm in github.com/aws/aws-sdk-go Note

Your code depends on 1 vulnerable module (github.com/aws/aws-sdk-go), but doesn't appear to call any of the vulnerable symbols.
@@ -1,4 +1,4 @@
module github.com/evmos/ethermint
module github.com/zeta-chain/ethermint

Check failure

Code scanning / govulncheck

[GO-2023-1821] The x/crisis package does not cause chain halt in github.com/cosmos/cosmos-sdk Error

Your code calls vulnerable functions in 1 package (github.com/cosmos/cosmos-sdk/x/crisis).
@@ -1,4 +1,4 @@
module github.com/evmos/ethermint
module github.com/zeta-chain/ethermint

Check failure

Code scanning / govulncheck

[GO-2023-1881] The x/crisis package does not charge ConstantFee in github.com/cosmos/cosmos-sdk Error

Your code calls vulnerable functions in 1 package (github.com/cosmos/cosmos-sdk/x/crisis).
@@ -1,4 +1,4 @@
module github.com/evmos/ethermint
module github.com/zeta-chain/ethermint

Check notice

Code scanning / govulncheck

[GO-2023-2402] Man-in-the-middle attacker can compromise integrity of secure channel in golang.org/x/crypto Note

Your code depends on 1 vulnerable module (golang.org/x/crypto), but doesn't appear to call any of the vulnerable symbols.
@@ -1,4 +1,4 @@
module github.com/evmos/ethermint
module github.com/zeta-chain/ethermint

Check failure

Code scanning / govulncheck

[GO-2024-2611] Infinite loop in JSON unmarshaling in google.golang.org/protobuf Error

Your code calls vulnerable functions in 2 packages (google.golang.org/protobuf/encoding/protojson and google.golang.org/protobuf/internal/encoding/json).
@@ -1,4 +1,4 @@
module github.com/evmos/ethermint
module github.com/zeta-chain/ethermint

Check failure

Code scanning / govulncheck

[GO-2024-2694] Potential Reentrancy using Timeout Callbacks in ibc-hooks in github.com/cosmos/ibc-go Error

Your code calls vulnerable functions in 1 package (github.com/cosmos/ibc-go/v7/modules/core/keeper).
@@ -1,4 +1,4 @@
module github.com/evmos/ethermint
module github.com/zeta-chain/ethermint

Check failure

Code scanning / govulncheck

[GO-2024-2800] Argument injection when fetching remote default Git branches in github.com/hashicorp/go-getter Error

Your code calls vulnerable functions in 1 package (github.com/hashicorp/go-getter).
@@ -1,4 +1,4 @@
module github.com/evmos/ethermint
module github.com/zeta-chain/ethermint

Check notice

Code scanning / govulncheck

[GO-2024-2818] Consensus failures in github.com/btcsuite/btcd Note

Your code depends on 1 vulnerable module (github.com/btcsuite/btcd), but doesn't appear to call any of the vulnerable symbols.
@@ -1,4 +1,4 @@
module github.com/evmos/ethermint
module github.com/zeta-chain/ethermint

Check failure

Code scanning / govulncheck

[GO-2024-2948] Code Execution on Git update in github.com/hashicorp/go-getter Error

Your code calls vulnerable functions in 1 package (github.com/hashicorp/go-getter).
@@ -1,4 +1,4 @@
module github.com/evmos/ethermint
module github.com/zeta-chain/ethermint

Check failure

Code scanning / govulncheck

[GO-2024-2951] Denial of service when syncing with a malicious peer in github.com/cometbft/cometbft Error

Your code calls vulnerable functions in 1 package (github.com/cometbft/cometbft/blocksync).
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@fbac fbac force-pushed the fix-dependencies branch from a383bfd to 3af98a6 Compare July 25, 2024 11:10
@fbac fbac requested review from gartnera, lumtis and skosito July 25, 2024 11:48
@fbac fbac merged commit 5db67f1 into main Jul 25, 2024
31 of 34 checks passed
@fbac fbac deleted the fix-dependencies branch July 25, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: remove upstream dependencies
4 participants