-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dependencies should not point to upstream #87
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 228 files out of 286 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
@@ -1,4 +1,4 @@ | |||
module github.com/evmos/ethermint | |||
module github.com/zeta-chain/ethermint |
Check notice
Code scanning / govulncheck
[GO-2022-0646] Use of risky cryptographic algorithm in github.com/aws/aws-sdk-go Note
@@ -1,4 +1,4 @@ | |||
module github.com/evmos/ethermint | |||
module github.com/zeta-chain/ethermint |
Check failure
Code scanning / govulncheck
[GO-2023-1821] The x/crisis package does not cause chain halt in github.com/cosmos/cosmos-sdk Error
@@ -1,4 +1,4 @@ | |||
module github.com/evmos/ethermint | |||
module github.com/zeta-chain/ethermint |
Check failure
Code scanning / govulncheck
[GO-2023-1881] The x/crisis package does not charge ConstantFee in github.com/cosmos/cosmos-sdk Error
@@ -1,4 +1,4 @@ | |||
module github.com/evmos/ethermint | |||
module github.com/zeta-chain/ethermint |
Check notice
Code scanning / govulncheck
[GO-2023-2402] Man-in-the-middle attacker can compromise integrity of secure channel in golang.org/x/crypto Note
@@ -1,4 +1,4 @@ | |||
module github.com/evmos/ethermint | |||
module github.com/zeta-chain/ethermint |
Check failure
Code scanning / govulncheck
[GO-2024-2611] Infinite loop in JSON unmarshaling in google.golang.org/protobuf Error
@@ -1,4 +1,4 @@ | |||
module github.com/evmos/ethermint | |||
module github.com/zeta-chain/ethermint |
Check failure
Code scanning / govulncheck
[GO-2024-2694] Potential Reentrancy using Timeout Callbacks in ibc-hooks in github.com/cosmos/ibc-go Error
@@ -1,4 +1,4 @@ | |||
module github.com/evmos/ethermint | |||
module github.com/zeta-chain/ethermint |
Check failure
Code scanning / govulncheck
[GO-2024-2800] Argument injection when fetching remote default Git branches in github.com/hashicorp/go-getter Error
@@ -1,4 +1,4 @@ | |||
module github.com/evmos/ethermint | |||
module github.com/zeta-chain/ethermint |
Check notice
Code scanning / govulncheck
[GO-2024-2818] Consensus failures in github.com/btcsuite/btcd Note
@@ -1,4 +1,4 @@ | |||
module github.com/evmos/ethermint | |||
module github.com/zeta-chain/ethermint |
Check failure
Code scanning / govulncheck
[GO-2024-2948] Code Execution on Git update in github.com/hashicorp/go-getter Error
@@ -1,4 +1,4 @@ | |||
module github.com/evmos/ethermint | |||
module github.com/zeta-chain/ethermint |
Check failure
Code scanning / govulncheck
[GO-2024-2951] Denial of service when syncing with a malicious peer in github.com/cometbft/cometbft Error
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Changes
Closes #85
The "fix" is just a replacing all evmos/ethermint for zeta-chain/ethermint.
Failures
govulncheck
detected vulnerabilities in packages actively used. Those should be fixed independently in its own issues.https://github.com/zeta-chain/ethermint/security/code-scanning?query=pr:87+tool:govulncheck+is:open
integration tests are successful except at the final python stages, looks good overall but we have to investigate if the python tests are needed for our use case, Opened ci: fix integration tests #89