Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v14 migration #1817

Closed
wants to merge 9 commits into from
Closed

feat: v14 migration #1817

wants to merge 9 commits into from

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Feb 28, 2024

Description

Hotfix: Resetes the pending nonces for testnet only. This would fix the issue caused by running the wrong migration script in v13 .
The new migration script still sets ZetaACccounting for mainnet , but does not reset the nonces .

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

app/setup_handlers.go Outdated Show resolved Hide resolved
x/crosschain/migrations/v5/migrate_test.go Show resolved Hide resolved
@lumtis lumtis changed the title release : v14 migration chore : v14 migration Feb 29, 2024
@lumtis lumtis changed the title chore : v14 migration chore: v14 migration Feb 29, 2024
@lumtis lumtis changed the title chore: v14 migration feat: v14 migration Feb 29, 2024
@lumtis
Copy link
Member

lumtis commented Feb 29, 2024

Added some logs for testing

kingpinXD and others added 3 commits February 29, 2024 13:29
* update mainnet btc deposit fee height

* delay dynamic depositor fee upgrade by 2 weeks
Copy link

!!!WARNING!!!
nosec detected in the following files: x/crosschain/migrations/v5/migrate.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Feb 29, 2024
@akimov99900
Copy link

x/crosschain/migrations/v5/migrate.go

@lumtis
Copy link
Member

lumtis commented Mar 4, 2024

Closing as released

@lumtis lumtis closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants