-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cosmos sdk 0.47.10 upgrade #2100
Conversation
* Remove unused params from fungible module * Make generate * Changelog * Lint fix * Lint fix
* Remove unused params from fungible module * Make generate * Changelog * Lint fix * Lint fix * Migrate emissions params to store * Migrate observer params to its own store * Make generate * Changelog * Lint fixes * Add observer slash amount param to migrate script * Fix tests * Lint fixes * Fixes * Lint fixes * Fixes * Tests * Small cleanup * Remove not needed params store mock * Fixes after merge * Add found flag to get params method * Move ballot maturity blocks param to emissions module * Remove params from observer module * Fix build * PR comments * PR comment * PR comments * PR comments
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2100 +/- ##
===========================================
- Coverage 70.74% 70.61% -0.14%
===========================================
Files 249 245 -4
Lines 14069 13976 -93
===========================================
- Hits 9953 9869 -84
+ Misses 3657 3650 -7
+ Partials 459 457 -2 |
These are the modifications? (looking at the entire diff is buggy to me because of the PR size) @gartnera maybe you can help on this one? 👀 |
yep I'll take a look proto-format needs a run it seems? I pushed a fix, let me know if you agree with my changes.
|
was referring to this one 6b8055c github.com/zetachain/zetacore/* was not generated in project folder, i guess {{github.workspace}}, what should happen when protoc gen script is run, without using root user, maybe there is better way, but this works running proto-format is not related, but it is good change, thanks for adding that cc: @gartnera |
Yes I will look into that too |
should be resolved now by:
|
nice, thank you |
* Remove unused params from fungible module * Make generate * Changelog * Lint fix * Lint fix * Migrate emissions params to store * Migrate observer params to its own store * Make generate * Changelog * Lint fixes * Add observer slash amount param to migrate script * Fix tests * Lint fixes * Fixes * Lint fixes * Fixes * Tests * Small cleanup * Try upgrade with simapp change * Remove not needed params store mock * fix compile errors * proto changes * Fixes * Upgrade handler changes * Fixes * Fix e2e test * Fixes after merge * Add found flag to get params method * Move ballot maturity blocks param to emissions module * Remove params from observer module * Fix build * Regen proto * Fixes for e2e tests * Fix some unit tests * Fix some lint errors * Fix more unit tests * PR comments * Proto paths fixes * Linters * make typescript * proto format * make specs * make docs * make gen * lint * Fix some unit tests * Fix cli test suites * Fix lints * Tmp comment unit test * lint * Use latest ethermint change and fix test * PR comment * PR comments * Fix one more import * Cleanup * Lint fix * Bump zetachain ethermint * Remove cometbft replace * go mod tidy * bump ethermint * Revert replace * Bump ethermint * Proto files updates after merge * Make generate * Bump ethermint * Fix PR comments * Formatting * Mention observer params removal in breaking changes in changelog * bump ethermint * Remove tendermint dep after go-tss upgrade * go mod tidy * bump go-tss * changelog * changelog
Description
Contains changes from these PRs:
#2039
#2014
One more PR left: #2094 to remove tendermint dependency completely
Closes: #1928
@lumtis @kingpinXD since you reviewed original PRs, only changes here are:
fixing of unit test: 70ceefa to remove observer params
make generate didnt work properly when running in github actions with new docker setup for proto-gen, please check changes with
make generate-ci
, i noticed other projects used same workaroundType of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: