-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move rate limiter to zetaclient and add metrics #2110
Conversation
…t-withdraw-rate-limit
Co-authored-by: Lucas Bertrand <[email protected]>
Co-authored-by: Lucas Bertrand <[email protected]>
Co-authored-by: Lucas Bertrand <[email protected]>
…it exceeds Rate; updated metrics
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2110 +/- ##
===========================================
+ Coverage 71.87% 72.30% +0.43%
===========================================
Files 245 247 +2
Lines 13730 13921 +191
===========================================
+ Hits 9868 10066 +198
+ Misses 3405 3394 -11
- Partials 457 461 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just some comments to consider before merging, mostly refactoring suggestions
Description
zetaclient
. The method is named asApplyRateLimiter
RateLimiterInput
.percentage_of_rate_reached
to monitor current rate.Closes: 2074
Closes: 2082
Closes: 2092
Closes: 2093
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: