Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify CI docker images #2158

Merged
merged 13 commits into from
May 14, 2024
Merged

refactor: unify CI docker images #2158

merged 13 commits into from
May 14, 2024

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented May 10, 2024

Description

  • unify the localnet and upgrade docker images by using a multistage build. you can stop a multistage build by using the --target option.
  • use debian instead of alpine for glibc compatibility. this means that we can deploy our real releases into the localnet containers.
  • always run zetacored under cosmovisor. all localnet builds can now accept and process upgrade proposals.
  • serve upgrade binaries from a sidecar container upgradehost
  • run the upgrade governance proposal from upgradeorchestrator
  • simplify the docker compose file a bit (docker-compose-upgrade-light.yml now inherits from docker-compose-upgrade.yml)
  • remove static ssh keys from docker build. ssh keys are now generated on first zetacored0 boot and stored on a volume. this will enable caching docker images to speed up CI. update: this highlighted a few race conditions that I had to fix.

Relates to #2146 #2147

Relates to DEVOP-642 DEVOP-643

How Has This Been Tested?

  • Tested in development environment
  • Go integration tests
  • Tested via GitHub Actions (upgrade tests pass)

Checklist:

  • light upgrade tests pass locally

@gartnera gartnera added the no-changelog Skip changelog CI check label May 10, 2024
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label May 10, 2024
@gartnera gartnera marked this pull request as ready for review May 13, 2024 15:38
Copy link
Contributor

@gzukel gzukel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a few minor comments

Dockerfile-localnet Show resolved Hide resolved
Dockerfile-localnet Outdated Show resolved Hide resolved
contrib/localnet/scripts/start-upgradehost.sh Outdated Show resolved Hide resolved
contrib/localnet/scripts/start-upgradeorchestrator.sh Outdated Show resolved Hide resolved
@lumtis lumtis linked an issue May 14, 2024 that may be closed by this pull request
@gartnera
Copy link
Member Author

upgrade tests are passing before final merge: https://github.com/zeta-chain/node/actions/runs/9082090862/job/24957575444

@gartnera gartnera merged commit 7370fac into develop May 14, 2024
24 of 25 checks passed
@gartnera gartnera deleted the unify-docker-images branch May 14, 2024 15:51
@gartnera gartnera mentioned this pull request May 15, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade tests failing
3 participants