Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use v22 as base in upgrade tests #3200

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Nov 22, 2024

Should also be backported to release/v23

Summary by CodeRabbit

  • New Features

    • Upgraded the software version from v21 to v22 for improved performance and features.
  • Bug Fixes

    • Resolved issues related to outdated version references in the build process.

Copy link
Contributor

coderabbitai bot commented Nov 22, 2024

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in this pull request focus on updating the versioning in the Makefile for the zetanode-upgrade target. The OLD_VERSION build argument has been modified to reflect the transition from version 21 to version 22, both in the source and binary build sections. This update involves changing the version string and the associated download URLs, ensuring that the build process references the correct version of the software.

Changes

File Change Summary
Makefile Updated OLD_VERSION from release/v21 to release/v22 and changed download URL from v21.0.0 to v22.0.0 in the zetanode-upgrade target.

Possibly related PRs

  • chore: use v21 as upgrade base #3063: This PR updates the Makefile to change the OLD_VERSION from release/v20 to release/v21, which is directly related to the versioning changes made in the main PR that updates from release/v21 to release/v22.
  • test: fix upgrade tests #3196: This PR addresses issues in upgrade tests and includes a condition to skip Bitcoin dust withdrawal for the v21 test run, which is relevant as the main PR also involves an upgrade in versioning for the zetanode-upgrade target.

Suggested labels

UPGRADE_TESTS, UPGRADE_IMPORT_MAINNET_TESTS

Suggested reviewers

  • skosito
  • fbac
  • kingpinXD
  • brewmaster012
  • swift1337
  • ws4charlie

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gartnera gartnera added the UPGRADE_LIGHT_TESTS Run make start-upgrade-test-light label Nov 22, 2024
@gartnera gartnera enabled auto-merge November 22, 2024 16:01
@gartnera gartnera added this pull request to the merge queue Nov 22, 2024
Merged via the queue into develop with commit 6510cf2 Nov 22, 2024
42 of 46 checks passed
@gartnera gartnera deleted the upgrade-test-v22-base branch November 22, 2024 16:54
gartnera added a commit that referenced this pull request Nov 22, 2024
* chore: use v22 as base in upgrade tests

* v22.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Skip changelog CI check UPGRADE_LIGHT_TESTS Run make start-upgrade-test-light
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants