-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: query solana inbound signatures using max version0 to avoid errors #3246
fix: query solana inbound signatures using max version0 to avoid errors #3246
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v23 #3246 +/- ##
============================================
Coverage 62.65% 62.66%
============================================
Files 424 424
Lines 30236 30234 -2
============================================
Hits 18945 18945
+ Misses 10451 10449 -2
Partials 840 840
|
Description
Athens is blocked by below RPC query error. This is because the function
GetSignaturesForAddressUntil
now only works when the passeduntilSig
argument is a legacy transaction. It returns error ifuntilSig
is a version "0" tx and blocks inbound observation.How Has This Been Tested?