Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(zetaclient): remove redundant getters/setters #3268

Merged
merged 6 commits into from
Dec 11, 2024

Merge branch 'develop' into refactor/minimize-apis

1a01dc1
Select commit
Loading
Failed to load commit list.
Merged

refactor(zetaclient): remove redundant getters/setters #3268

Merge branch 'develop' into refactor/minimize-apis
1a01dc1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 11, 2024 in 1s

61.72% (-0.09%) compared to 376b714

View this Pull Request on Codecov

61.72% (-0.09%) compared to 376b714

Details

Codecov Report

Attention: Patch coverage is 89.58333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.72%. Comparing base (376b714) to head (1a01dc1).

Files with missing lines Patch % Lines
zetaclient/chains/evm/observer/observer.go 0.00% 2 Missing ⚠️
zetaclient/orchestrator/bootstrap.go 50.00% 2 Missing ⚠️
zetaclient/orchestrator/orchestrator.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3268      +/-   ##
===========================================
- Coverage    61.81%   61.72%   -0.09%     
===========================================
  Files          432      432              
  Lines        30875    30809      -66     
===========================================
- Hits         19084    19016      -68     
- Misses       10930    10934       +4     
+ Partials       861      859       -2     
Files with missing lines Coverage Δ
zetaclient/chains/base/observer.go 81.46% <100.00%> (-3.90%) ⬇️
zetaclient/chains/base/signer.go 80.95% <100.00%> (-15.13%) ⬇️
zetaclient/chains/bitcoin/observer/observer.go 27.09% <ø> (-0.73%) ⬇️
zetaclient/chains/bitcoin/signer/signer.go 18.43% <100.00%> (ø)
zetaclient/chains/evm/signer/signer.go 44.32% <100.00%> (-0.07%) ⬇️
zetaclient/chains/solana/observer/observer.go 43.47% <ø> (+1.58%) ⬆️
zetaclient/chains/solana/signer/signer.go 23.23% <100.00%> (ø)
zetaclient/orchestrator/orchestrator.go 18.45% <0.00%> (ø)
zetaclient/chains/evm/observer/observer.go 69.23% <0.00%> (-0.36%) ⬇️
zetaclient/orchestrator/bootstrap.go 58.80% <50.00%> (-0.25%) ⬇️