-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(changelogs): add breaking changes for v27 #3453
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe changelog has been updated to include a new "Breaking Changes" section for version 27.0.0. This section specifies that universal contract calls for the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Gateway
participant UniversalContract as "Universal Contract"
participant SystemContract as "System Contract"
Client->>Gateway: Request depositAndCall / call
Gateway->>UniversalContract: Invoke onCall (Protocol Contract V2)
Note over Gateway,UniversalContract: Replaces previous call via systemContract's onCrossChainCall
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
changelog.md (1)
8-8
: Refine Inline Code Formatting for Consistency.The sentence “For
depositAndCall
andcall operations
, theonCall
method is invoked on the Universal Contract from the gateway…” would be clearer if “call operations” were formatted consistently. Consider revising it to “FordepositAndCall
andcall
operations, …” so that both function names appear with proper inline code formatting.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
changelog.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: build-zetanode
- GitHub Check: lint
- GitHub Check: build-and-test
- GitHub Check: gosec
- GitHub Check: build
- GitHub Check: Analyze (go)
🔇 Additional comments (3)
changelog.md (3)
5-5
: Introduce the "Breaking Changes" section clearly.The addition of the "Breaking Changes" header for v27.0.0 is clear and fits the purpose of documenting critical updates. Ensure that the markdown syntax (header level) is consistent with the rest of the document.
7-7
: Clear Description of Workflow Change.The bullet point “Universal contract calls from Bitcoin and Solana now follow the Protocol Contract V2 workflow.” succinctly describes the major change. Verify that this statement accurately reflects the documented behavior in the PR summary and internal documentation.
9-9
: Affirmation of Interface Stability.The note “The interfaces of both functions remain the same.” effectively reassures users that, despite the workflow changes, the public interfaces are unchanged. No modifications are required for this line.
Co-authored-by: skosito <[email protected]>
Breaking changes related to Solana and Bitcoin Universal Contracts
Summary by CodeRabbit