Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): sui withdraws #3595

Merged
merged 54 commits into from
Mar 4, 2025
Merged

test(e2e): sui withdraws #3595

merged 54 commits into from
Mar 4, 2025

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Feb 26, 2025

  • Add TSS address in Sui format for the TSS address query
  • Add E2E tests for deposit_and_call_revert and withdraw for SUI and Sui fungible token
  • Any fixes necessary to make the tests pass

Summary by CodeRabbit

  • New Features

    • Enhanced Sui blockchain support with expanded cross-chain deposit, withdrawal, and error-reversion operations.
    • Increased Sui token minting and added a genesis account setup for Sui testers.
    • Integrated Sui address retrieval into cross-chain processing.
  • Tests

    • Introduced comprehensive end-to-end tests covering various Sui transaction scenarios.
  • Documentation

    • Updated API definitions to include a new Sui property in response payloads.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 67.24138% with 19 lines in your changes missing coverage. Please review.

Project coverage is 64.54%. Comparing base (e9b9bce) to head (18009d2).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
x/observer/keeper/grpc_query_tss.go 62.50% 4 Missing and 2 partials ⚠️
zetaclient/chains/sui/signer/signer_tx.go 53.84% 5 Missing and 1 partial ⚠️
pkg/crypto/tss.go 78.57% 2 Missing and 1 partial ⚠️
pkg/chains/chain.go 0.00% 2 Missing ⚠️
zetaclient/chains/solana/signer/signer.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3595      +/-   ##
===========================================
- Coverage    64.55%   64.54%   -0.01%     
===========================================
  Files          469      469              
  Lines        32723    32760      +37     
===========================================
+ Hits         21123    21145      +22     
- Misses       10639    10650      +11     
- Partials       961      965       +4     
Files with missing lines Coverage Δ
...chain/keeper/cctx_orchestrator_validate_inbound.go 90.32% <100.00%> (ø)
x/crosschain/types/cctx.go 49.17% <100.00%> (+1.07%) ⬆️
x/crosschain/types/cmd_cctxs.go 96.79% <100.00%> (ø)
pkg/chains/chain.go 81.93% <0.00%> (-1.08%) ⬇️
zetaclient/chains/solana/signer/signer.go 11.72% <0.00%> (ø)
pkg/crypto/tss.go 76.92% <78.57%> (-2.39%) ⬇️
x/observer/keeper/grpc_query_tss.go 78.57% <62.50%> (-4.77%) ⬇️
zetaclient/chains/sui/signer/signer_tx.go 61.53% <53.84%> (-1.62%) ⬇️

@lumtis lumtis linked an issue Feb 28, 2025 that may be closed by this pull request
@lumtis lumtis added this pull request to the merge queue Mar 4, 2025
@github-actions github-actions bot added the MERGE_FAILED Merge Queue CI failed label Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
@lumtis lumtis added this pull request to the merge queue Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
@lumtis lumtis added the CONSENSUS_BREAKING_ACK Acknowledge a consensus breaking change label Mar 4, 2025
@lumtis lumtis enabled auto-merge March 4, 2025 13:18
@lumtis lumtis added this pull request to the merge queue Mar 4, 2025
Merged via the queue into develop with commit f104014 Mar 4, 2025
45 checks passed
@lumtis lumtis deleted the sui-withdraw-e2e branch March 4, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:cli breaking:proto CONSENSUS_BREAKING_ACK Acknowledge a consensus breaking change MERGE_FAILED Merge Queue CI failed nosec SUI_TESTS Run make start-sui-tests UPGRADE_TESTS Run make start-upgrade-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement E2E tests for Sui withdraws
4 participants