Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(proto): add a make target to format proto and format proto files #876

Merged
merged 7 commits into from
Aug 2, 2023

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Jul 31, 2023

Description

Add the target

make proto-format

The command format the proto files using buf.
Run the target in the codebase.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis changed the title chore(proto): add a make target for formatting proto and format proto files chore(proto): add a make target to format proto and format proto files Jul 31, 2023
@lumtis lumtis self-assigned this Jul 31, 2023
Copy link
Member

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This could be added as a workflow #877

@lumtis lumtis merged commit 5e1ac4b into develop Aug 2, 2023
17 checks passed
@lumtis lumtis deleted the format/proto branch August 2, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants