fix: audit findings

[skosito]

https://github.com/zeta-chain/protocol-private/issues/189
https://github.com/zeta-chain/protocol-private/issues/183
https://github.com/zeta-chain/protocol-private/issues/185
https://github.com/zeta-chain/protocol-private/issues/187

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 118 lines in your changes missing coverage. Please review.

Project coverage is 1.09%. Comparing base (2533cc1) to head (80c79e8).

Files with missing lines	Patch %	Lines
programs/gateway/src/lib.rs	0.00%	118 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##            main     #71      +/-   ##
========================================
- Coverage   5.85%   1.09%   -4.76%     
========================================
  Files          1       1              
  Lines        410     456      +46     
========================================
- Hits          24       5      -19     
- Misses       386     451      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lumtis]

Regarding the unit testing, we actually have codecov integrated for Solana smart contract but the number remains low: https://app.codecov.io/gh/zeta-chain/protocol-contracts-solana/tree/non-security-related-findings/programs%2Fgateway%2Fsrc
Is there some configuration missing here?

[skosito]

Regarding the unit testing, we actually have codecov integrated for Solana smart contract but the number remains low: https://app.codecov.io/gh/zeta-chain/protocol-contracts-solana/tree/non-security-related-findings/programs%2Fgateway%2Fsrc Is there some configuration missing here?

not sure why we have that workflow, we have anchor js tests, and this seems like it is checking if we have rust tests, maybe we can open issue for it

i added tests that are marked in audit findings as missing, so i think we can close this one and follow up on codecov, at first look i didnt find some easy built in tool for it