chore: Add Base Testnet data #284
Conversation
julianrubino
requested review from
andresaiello,
brewmaster012,
lumtis,
CharlieMc0,
fadeev,
skosito and
fbac
as code owners
WalkthroughThe recent updates enhance the blockchain development landscape by introducing the "base_testnet." This new configuration is integrated into several files, providing essential parameters for smart contract interactions and improving the testing environment. The enhancements focus on flexibility and efficiency for developers, facilitating smoother deployment processes within the blockchain ecosystem. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Hardhat
participant BaseTestnet
participant SmartContracts
Developer->>Hardhat: Configure base_testnet
Hardhat->>BaseTestnet: Connect to API
BaseTestnet->>SmartContracts: Deploy contracts
SmartContracts-->>BaseTestnet: Confirm deployment
BaseTestnet-->>Hardhat: Return transaction details
Hardhat-->>Developer: Provide feedback on deployment
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (6)
- v1/data/addresses.json (1 hunks)
- v1/data/addresses.testnet.json (1 hunks)
- v1/hardhat.config.ts (2 hunks)
- v1/lib/address.tools.ts (1 hunks)
- v1/lib/contracts.constants.ts (1 hunks)
- v1/lib/contracts.helpers.ts (1 hunks)
Additional context used
GitHub Check: lint
v1/hardhat.config.ts
[failure] 30-30:
Expected object keys to be in ascending order. 'base_testnet' should be before 'mainnet'
[failure] 41-41:
Insert⏎······
Gitleaks
v1/data/addresses.json
90-90: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
Additional comments not posted (12)
v1/lib/contracts.constants.ts (1)
69-74: Verify the appropriateness of default values forbase_testnet.The new entry for
base_testnetassigns default values ("0") to several keys. Ensure these values are correct and appropriate for the test network.v1/hardhat.config.ts (2)
30-30: Ensure theBASESCAN_API_KEYenvironment variable is set.The new entry for
base_testnetusesprocess.env.BASESCAN_API_KEYor an empty string. Verify that the environment variable is correctly set in the deployment environment.Tools
GitHub Check: lint
[failure] 30-30:
Expected object keys to be in ascending order. 'base_testnet' should be before 'mainnet'
41-47: Verify the correctness ofchainIdand URLs forbase_testnet.The new entry for
base_testnetdefineschainId,networkname, and URLs for the API and browser interfaces. Ensure these values are correct and consistent with the actual test network configuration.Tools
GitHub Check: lint
[failure] 41-41:
Insert⏎······v1/lib/address.tools.ts (2)
38-38: Verify the correctness of the new entry forbase_testnetinZetaProtocolTestNetwork.The new entry for
base_testnetadds it as a recognized test network. Ensure this addition is correct and consistent with other test network entries.
46-46: Verify the correctness of the new entry forbase_testnetinzetaProtocolTestNetworks.The new entry for
base_testnetadds it to the list of recognized test networks. Ensure this addition is correct and consistent with other test network entries.v1/lib/contracts.helpers.ts (1)
32-33: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
isEthNetworkNameare updated to recognize the new network name.Verification successful
Function usage verified successfully.
The function
isEthNetworkNameis correctly utilized across the codebase, and the new network namebase_testnetis recognized in all relevant places.
v1/scripts/tools/update-tss-address.tsv1/scripts/deployments/tools/deterministic-get-salt-zeta-connector.tsv1/scripts/deployments/core/deterministic-deploy-zeta-token.tsv1/scripts/deployments/tools/deterministic-get-salt-zeta-token.tsv1/scripts/deployments/core/deploy-zeta-connector.tsv1/scripts/tools/token-approval.tsv1/scripts/deployments/core/deterministic-deploy-zeta-connector.tsv1/scripts/deployments/core/deploy-zeta-token.tsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `isEthNetworkName` recognize the new network name. # Test: Search for the function usage. Expect: Only occurrences of the new network name. rg --type typescript -A 5 $'isEthNetworkName'Length of output: 79
Script:
#!/bin/bash # Description: Verify all function calls to `isEthNetworkName` recognize the new network name. # Test: Search for the function usage in all TypeScript files. rg 'isEthNetworkName' --glob '*.ts' -A 5Length of output: 9845
v1/data/addresses.json (1)
85-93: LGTM!The addition of the
base_testnetsection is consistent with the existing structure.Tools
Gitleaks
90-90: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
v1/data/addresses.testnet.json (5)
385-390: LGTM!The addition of the
base_testnetentries is consistent with the existing structure.
391-397: LGTM!The addition of the
base_testnetentries is consistent with the existing structure.
398-404: LGTM!The addition of the
base_testnetentries is consistent with the existing structure.
405-411: LGTM!The addition of the
base_testnetentries is consistent with the existing structure.
412-417: LGTM!The addition of the
base_testnetentries is consistent with the existing structure.
|
Besides the linter error it looks good to me. I'd like @lumtis to confirm though. |
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
v1/data/addresses.json (1)
85-85: Add a description for the new section.Consider adding a brief description or comment for the
base_testnetsection to provide context for its purpose.+ // Base Testnet configuration
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- v1/data/addresses.json (1 hunks)
- v1/hardhat.config.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- v1/hardhat.config.ts
Additional context used
Gitleaks
v1/data/addresses.json
91-91: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
Additional comments not posted (6)
v1/data/addresses.json (6)
86-86: Ensure theconnectoraddress is correct.Verify that the
connectoraddress0x6A269Be3e414e4617f01231a2485FB692C53f748is correct and intended for thebase_testnet.
87-87: Ensure theimmutableCreate2Factoryaddress is correct.Verify that the
immutableCreate2Factoryaddress0x095a03c6a68137fE9a566bBc3e552F299d8b886dis correct and intended for thebase_testnet.
88-88: Ensure theerc20Custodyaddress is correct.Verify that the
erc20Custodyaddress0x44e8ED4a36670966C292a21EC15C9E43502d3CB3is correct and intended for thebase_testnet.
89-89: Ensure thetssaddress is correct.Verify that the
tssaddress0x8531a5aB847ff5B22D855633C25ED1DA3255247eis correct and intended for thebase_testnet.
90-90: Ensure thetssUpdateraddress is correct.Verify that the
tssUpdateraddress0xdE3fb63723f0EEed8967ff9124e1c3bA89871b03is correct and intended for thebase_testnet.
92-93: Ensure thezetaTokenConsumerUniV2andzetaTokenConsumerUniV3fields are correct.The
zetaTokenConsumerUniV2andzetaTokenConsumerUniV3fields are currently empty. Verify if this is intentional or if they need to be populated.
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (2)
v1/data/addresses.json (1)
85-85: Add a comment to explain the purpose ofbase_testnet.Adding a brief comment to explain the purpose and usage of the
base_testnetsection would improve readability and maintainability.v1/data/addresses.testnet.json (1)
385-390: Add a comment to explain the purpose ofbase_testnet.Adding a brief comment to explain the purpose and usage of the
base_testnetsection would improve readability and maintainability.
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- v1/data/addresses.json (1 hunks)
- v1/data/addresses.testnet.json (1 hunks)
Additional context used
Gitleaks
v1/data/addresses.json
91-91: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
Additional comments not posted (1)
v1/data/addresses.testnet.json (1)
399-403: Potential API Key exposure.The address
0xf4e63991E7475b659bd97Bba85f32a7259239D5din thezetaTokenfield may be a Generic API Key. Ensure that it is not exposing sensitive information.- "address": "0xf4e63991E7475b659bd97Bba85f32a7259239D5d" + "address": "<secure_value>"Likely invalid or redundant comment.
Summary by CodeRabbit
New Features
base_testnetconfiguration with key parameters for enhanced smart contract interactions.base_testnet, providing additional resources for developers.Bug Fixes
Documentation
Tests
Chores
Revert