-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update package.json order, and touch files for CI #379
Conversation
Caution Review failedThe pull request is closed. 📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
v1/package.json (1)
95-95
: Consider version bumpThe version remains unchanged at "0.0.8". While this aligns with the PR objectives, which don't mention any version updates, it's worth considering:
- Adding a new dependency (chokidar) could be seen as a significant change that warrants a version bump, especially if it affects the project's functionality or dependencies.
- If you decide to bump the version, follow semantic versioning principles. For a new dependency, you might want to increment the minor version (e.g., 0.1.0) or the patch version (e.g., 0.0.9) depending on the impact of the change.
Would you like to update the version number in this PR, or do you prefer to keep it unchanged for now?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- v1/package.json (2 hunks)
🧰 Additional context used
🔇 Additional comments (1)
v1/package.json (1)
3-5
: Approve addition of chokidar, but suggest reorderingThe addition of "chokidar" as a dependency aligns with the PR objectives. However, I have a few suggestions:
To maintain consistency, consider moving "chokidar" to maintain alphabetical order within the
dependencies
section.The AI summary mentions that a previous entry for "chokidar" was removed, but this is not visible in the provided diff. Could you please verify if there was indeed a previous entry that was removed?
To verify the previous "chokidar" entry and check the ordering, please run the following script:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (2)
v1/data/addresses.json
is excluded by!v1/data/**
v1/data/addresses.mainnet.json
is excluded by!v1/data/**
📒 Files selected for processing (1)
- v1/hardhat.config.ts (1 hunks)
🧰 Additional context used
🪛 GitHub Check: lint
v1/hardhat.config.ts
[failure] 94-94:
Delete⏎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fadeev / anyone: I'm not sure that a hard dependency on "chokidar" is correct.
This PR will:
Summary by CodeRabbit
chokidar
dependency from project configurations.