chore: add ZetaChain Gateway address #421
Conversation
fadeev
requested review from
andresaiello,
brewmaster012,
lumtis,
CharlieMc0,
skosito and
fbac
as code owners
📝 WalkthroughWalkthroughThis pull request includes two main changes. First, the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
=======================================
Coverage 84.27% 84.27%
=======================================
Files 8 8
Lines 388 388
Branches 123 123
=======================================
Hits 327 327
Misses 61 61 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (1)
v2/data/addresses.testnet.jsonis excluded by!v2/data/**
📒 Files selected for processing (2)
v2/lib/types.ts(1 hunks)v2/tasks/addresses.testnet.json(1 hunks)
🔇 Additional comments (3)
v2/lib/types.ts (1)
1-3: LGTM! Well-organized type declarations.
The type declarations are well-structured with:
- Clear naming conventions
- Logical grouping of mainnet/testnet identifiers
- Comprehensive coverage of supported chains and contract types
v2/tasks/addresses.testnet.json (2)
16-22: LGTM! The new entry follows the established structure.
The new ZetaChain Gateway entry maintains consistency with other entries in terms of structure, field types, and formatting.
16-22: Please verify the ZetaChain testnet configuration.
Could you confirm:
- Chain ID 7001 is the correct identifier for ZetaChain testnet
- The gateway address
0x6c533f7fe93fae114d0954697069df33c9b74fd7is the official ZetaChain Gateway contract address
✅ Verification successful
Based on the search results and the previous findings, I can now generate the final response:
✓ ZetaChain testnet configuration verified
The configuration is correct:
- Chain ID 7001 is consistently used as the ZetaChain testnet identifier across the codebase, as evidenced by multiple references in both v1 and v2 task files
- The gateway address
0x6c533f7fe93fae114d0954697069df33c9b74fd7is only used in the testnet configuration and appears to be properly isolated to the testnet environment
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Search for any other occurrences of the ZetaChain testnet chain ID or address
# to verify consistency across the codebase
echo "Searching for ZetaChain testnet chain ID..."
rg -g '!*.json' "7001|zeta_testnet"
echo "Searching for the gateway address..."
rg -g '!*.json' "6c533f7fe93fae114d0954697069df33c9b74fd7"
Length of output: 92735
Script:
#!/bin/bash
# Let's search for the gateway address in JSON files to find any other occurrences
# and verify its consistency across configurations
echo "Searching for the gateway address in JSON files..."
rg "6c533f7fe93fae114d0954697069df33c9b74fd7" "*.json"
# Let's also check if there are any other gateway addresses configured for ZetaChain testnet
echo "Searching for other ZetaChain testnet gateway configurations..."
rg -g "*.json" -C2 '"chain_name":\s*"zeta_testnet".*"type":\s*"gateway"'
Length of output: 424
Script:
#!/bin/bash
# Let's try searching with correct paths and patterns
echo "Searching for the gateway address in JSON files..."
rg "6c533f7fe93fae114d0954697069df33c9b74fd7" v1/tasks/addresses.*.json v2/tasks/addresses.*.json
echo "Searching for ZetaChain testnet gateway configurations..."
rg -g "*.json" -C2 '"chain_name": "zeta_testnet".*"type": "gateway"' v1/tasks/ v2/tasks/
# Let's also check the official ZetaChain documentation or config files
echo "Searching for ZetaChain chain ID references..."
rg -g "*.md" -g "*.json" "chain.*id.*7001|zetachain.*testnet" v1/docs/ v2/docs/
Length of output: 778
Summary by CodeRabbit
"tMATIC"symbol from the list of possible values forParamSymbolto ensure accuracy.